Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CUDA] Treat nvptx triple as alias for nvptx64 #1420

Merged
merged 5 commits into from
Mar 5, 2025
Merged

[CIR][CUDA] Treat nvptx triple as alias for nvptx64 #1420

merged 5 commits into from
Mar 5, 2025

Conversation

advay168
Copy link
Contributor

Similar to OG

@advay168
Copy link
Contributor Author

Also is there any reason CIRGenModule::getTargetCIRGenInfo() is implemented in clang/lib/CIR/CodeGen/TargetInfo.cpp and not clang/lib/CIR/CodeGen/CirGenModule.cpp. Would you be open to a PR for porting it?

@bcardosolopes
Copy link
Member

Also is there any reason CIRGenModule::getTargetCIRGenInfo() is implemented in clang/lib/CIR/CodeGen/TargetInfo.cpp and not clang/lib/CIR/CodeGen/CirGenModule.cpp. Would you be open to a PR for porting it?

No good reason, the closer to OG the betters, a PR would be welcome! Thanks

bcardosolopes
bcardosolopes reviewed Mar 1, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test needs be a little shorter.

@advay168
Copy link
Contributor Author

advay168 commented Mar 2, 2025

I have shortened the testcase down.

bcardosolopes
bcardosolopes approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending conflict fix!

@bcardosolopes bcardosolopes merged commit d4fbab3 into llvm:main Mar 5, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdUhTkJm AdUhTkJm

@bcardosolopes bcardosolopes

@lanza lanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@advay168 @bcardosolopes @AdUhTkJm