[CIR][CIRGen] Replace LLVMIntrinsicCallOp with ACosOp in __builtin_elementwise_acos #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayokunle321
changed the title
|
Seems like tests are failing. You also need to add tests for this (or maybe fixing the current failures would do that). |
Thanks for the reply! The tests are failing because of a build error: no member named 'ACosOp' in namespace 'mlir::LLVM' from LowerToLLVM.cpp. I think it would be fine after the rebase with llvm-project since it's been patched up there. There are already tests for |
|
|
|
Anyways, your PR should add a test when ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1374
@bcardosolopes @FantasqueX This is a draft PR to see if everything's good. Was also wondering if we need to add ACosOp to CIR documentation and also implement the other Ops such as asin.