[CIR] Implement ::verify for cir.atomic.xchg and cir.atomic.cmp_xchg

[Icaro-Nunes]

Implements ::verify for operations cir.atomic.xchg and cir.atomic.cmp_xchg

I believe the existing regression tests don't get to the CIR level type check failure and I was not able to implement a case that does.

Most attempts of reproducing cir.atomic.xchg type check failure were along the lines of:

int a;
long long b,c;
__atomic_exchange(&a, &b, &c, memory_order_seq_cst);

And they seem to never trigger the failure on ::verify because they fail earlier in function parameter checking:

exmp.cpp:7:27: error: cannot initialize a parameter of type 'int *' with an rvalue of type 'long long *'
    7 |     __atomic_exchange(&a, &b, &c, memory_order_seq_cst);
      |                           ^~

Closes #1378 .

[Icaro-Nunes]

@bcardosolopes is this the expected result? Failure at ::verify should happen only in the occasion of AST/CIRCodeGen bugs?

[bcardosolopes]

Thanks, this is great! To add a testcase, see clang/test/CIR/IR/invalid.cir for inspiration

[Icaro-Nunes]

@bcardosolopes I corrected the code where requested and added the tests (clang/test/CIR/IR/invalid.cir itself seemed like the appropriate place for them)

[bcardosolopes]

Awesome, thanks!

[bcardosolopes]

I'll land once tests pass

[github-actions]

✅ With the latest revision this PR passed the C/C++ code formatter.

[bcardosolopes]

clang-format issues need fixing before landing!

[Icaro-Nunes]

Done!