[CIR] Add default alignment to createStore #1433
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FantasqueX
force-pushed
the
createstore-default-alignment
branch
from
eefe2d7 to
4a2d639
Compare
|
@bcardosolopes Hi, could you please take a look at this PR before it is ready? Currently, there are 140 test cases failing still. I want to make sure my direction is correct before continuing to work. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, CIR's
createStoredoesn't add alignment by default while OG does. CIR adds alignment in lowering stage if missing alignment attribute by inferring size of type. However, this could be inaccurate. This change will break a lot of test cases. But I think we should do this as early as we can.Resolves: #1204