Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CIR][CIRGen][TBAA] Add support for enum #1435

Merged
merged 3 commits into from
Mar 5, 2025
Merged

[CIR][CIRGen][TBAA] Add support for enum #1435

merged 3 commits into from
Mar 5, 2025

Conversation

PikachuHyA
Copy link
Collaborator

No description provided.

@PikachuHyA
Copy link
Collaborator Author

After this patch, TBAA support for enum types has been implemented. How should we handle the cir::MissingFeatures::tbaaTagForEnum() function? Currently, I have marked the function to return true, but I left the original assertion assert(cir::MissingFeatures::tbaaTagForEnum()); in place.

@bcardosolopes
Copy link
Member

How should we handle the cir::MissingFeatures::tbaaTagForEnum() function?

Do you consider it done? If so we should remove

bcardosolopes
bcardosolopes approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, few nits

@bcardosolopes bcardosolopes merged commit d9eeb83 into llvm:main Mar 5, 2025
6 checks passed
@PikachuHyA PikachuHyA deleted the tbaa-enum branch March 6, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes

@lanza lanza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PikachuHyA @bcardosolopes