[msan][NFC] Add tests for Arm NEON smaxv/sminv #129741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch precommits tests for the smaxv/sminv intrinsics, which are currently handled suboptimally by visitInstruction. These are the signed versions of umaxv/uminv (llvm#129661). Future work will update MSan to apply handleVectorReduceIntrinsic.
thurstond
changed the title
Maybe split into a separate CL? |
This reverts commit 437f872.
thurstond
changed the title
vitalybuka
approved these changes
Mar 5, 2025
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Mar 5, 2025
Changes the handling of: - llvm.aarch64.neon.smaxv - llvm.aarch64.neon.sminv - llvm.aarch64.neon.umaxv - llvm.aarch64.neon.uminv - llvm.vector.reduce.smax - llvm.vector.reduce.smin - llvm.vector.reduce.umax - llvm.vector.reduce.umin - llvm.vector.reduce.fmax - llvm.vector.reduce.fmin from the default strict handling (visitInstruction) to handleVectorReduceIntrinsic. Updates the tests from llvm#129741, llvm#129810, llvm#129768
thurstond
added a commit
that referenced
this pull request
Mar 9, 2025
…ns (#129819) Changes the handling of: - llvm.aarch64.neon.smaxv - llvm.aarch64.neon.sminv - llvm.aarch64.neon.umaxv - llvm.aarch64.neon.uminv - llvm.vector.reduce.smax - llvm.vector.reduce.smin - llvm.vector.reduce.umax - llvm.vector.reduce.umin - llvm.vector.reduce.fmax - llvm.vector.reduce.fmin from the default strict handling (visitInstruction) to handleVectorReduceIntrinsic. Also adds a parameter to handleVectorReduceIntrinsic to specify whether the return type must match the elements of the vector. Updates the tests from #129741, #129810, #129768
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 9, 2025
… instructions (#129819) Changes the handling of: - llvm.aarch64.neon.smaxv - llvm.aarch64.neon.sminv - llvm.aarch64.neon.umaxv - llvm.aarch64.neon.uminv - llvm.vector.reduce.smax - llvm.vector.reduce.smin - llvm.vector.reduce.umax - llvm.vector.reduce.umin - llvm.vector.reduce.fmax - llvm.vector.reduce.fmin from the default strict handling (visitInstruction) to handleVectorReduceIntrinsic. Also adds a parameter to handleVectorReduceIntrinsic to specify whether the return type must match the elements of the vector. Updates the tests from llvm/llvm-project#129741, llvm/llvm-project#129810, llvm/llvm-project#129768
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch precommits tests for the smaxv/sminv intrinsics, which are currently handled suboptimally by visitInstruction.
These are the signed versions of umaxv/uminv (#129661).
Future work will update MSan to apply handleVectorReduceIntrinsic.