[msan][NFC] Add arm64-vmax.ll tests #129760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked from llvm/test/CodeGen/AArch64/arm64-vmax.ll Pairwise instructions which are handled incorrectly by heuristics: - llvm.aarch64.neon.fmaxp (floating-point maximum pairwise) - llvm.aarch64.neon.fminp - llvm.aarch64.neon.fmaxnmp (floating-point maximum number pairwise) - llvm.aarch64.neon.fminnmp - llvm.aarch64.neon.smaxp - llvm.aarch64.neon.sminp - llvm.aarch64.neon.umaxp - llvm.aarch64.neon.uminp Future work should consider whether handlePairwiseShadowOrIntrinsic is a more appropriate handler. Other instructions which are handled correctly by heuristics: - llvm.aarch64.neon.fmax - llvm.aarch64.neon.fmin - llvm.aarch64.neon.smax - llvm.aarch64.neon.smin - llvm.aarch64.neon.umax - llvm.aarch64.neon.umin
fmayer
approved these changes
Mar 5, 2025
thurstond
added a commit
to thurstond/llvm-project
that referenced
this pull request
Mar 5, 2025
Change the handling of: - llvm.aarch64.neon.fmaxp - llvm.aarch64.neon.fminp - llvm.aarch64.neon.fmaxnmp - llvm.aarch64.neon.fminnmp - llvm.aarch64.neon.smaxp - llvm.aarch64.neon.sminp - llvm.aarch64.neon.umaxp - llvm.aarch64.neon.uminp from the incorrect heuristic handler (maybeHandleSimpleNomemIntrinsic) to handlePairwiseShadowOrIntrinsic. Updates the tests from llvm#129760
thurstond
added a commit
that referenced
this pull request
Mar 9, 2025
Change the handling of: - llvm.aarch64.neon.fmaxp - llvm.aarch64.neon.fminp - llvm.aarch64.neon.fmaxnmp - llvm.aarch64.neon.fminnmp - llvm.aarch64.neon.smaxp - llvm.aarch64.neon.sminp - llvm.aarch64.neon.umaxp - llvm.aarch64.neon.uminp from the incorrect heuristic handler (maybeHandleSimpleNomemIntrinsic) to handlePairwiseShadowOrIntrinsic. Updates the tests from #129760 Adds a note that maybeHandleSimpleNomemIntrinsic may incorrectly match horizontal/pairwise intrinsics.
llvm-sync bot
pushed a commit
to arm/arm-toolchain
that referenced
this pull request
Mar 9, 2025
…824) Change the handling of: - llvm.aarch64.neon.fmaxp - llvm.aarch64.neon.fminp - llvm.aarch64.neon.fmaxnmp - llvm.aarch64.neon.fminnmp - llvm.aarch64.neon.smaxp - llvm.aarch64.neon.sminp - llvm.aarch64.neon.umaxp - llvm.aarch64.neon.uminp from the incorrect heuristic handler (maybeHandleSimpleNomemIntrinsic) to handlePairwiseShadowOrIntrinsic. Updates the tests from llvm/llvm-project#129760 Adds a note that maybeHandleSimpleNomemIntrinsic may incorrectly match horizontal/pairwise intrinsics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked from llvm/test/CodeGen/AArch64/arm64-vmax.ll
Pairwise instructions which are handled incorrectly by heuristics:
Future work should consider whether handlePairwiseShadowOrIntrinsic is a more appropriate handler.
Other instructions which are handled correctly by heuristics: