Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking โ€œSign up for GitHubโ€, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: support bedrock endpoint configuration with env variable #6215

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oliviamn
Copy link

๐Ÿ’ป ๅ˜ๆ›ด็ฑปๅž‹ | Change Type

  • โœจ feat
  • ๐Ÿ› fix
  • โ™ป๏ธ refactor
  • ๐Ÿ’„ style
  • ๐Ÿ‘ท build
  • โšก๏ธ perf
  • ๐Ÿ“ docs
  • ๐Ÿ”จ chore

๐Ÿ”€ ๅ˜ๆ›ด่ฏดๆ˜Ž | Description of Change

  1. Add support for Bedrock endpoint setup by using environment variables

๐Ÿ“ ่กฅๅ……ไฟกๆฏ | Additional Information

add environment variable: AWS_ENDPOINT_URL_BEDROCK_RUNTIME to support bedrock proxy

it resolves the issue(feat request):#4815
user can set environment variable after following the project: https://github.com/jief123/bedrockproxy/blob/main/howto.md

AWS_ENDPOINT_URL_BEDROCK_RUNTIME="https://xxx.cloudfront.net"

Copy link

vercel bot commented Feb 16, 2025

@oliviamn is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 16, 2025
@lobehubbot
Copy link
Member

๐Ÿ‘ @oliviamn

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
้žๅธธๆ„Ÿ่ฐขๆ‚จๆๅ‡บๆ‹‰ๅ–่ฏทๆฑ‚ๅนถไธบๆˆ‘ไปฌ็š„็คพๅŒบๅšๅ‡บ่ดก็Œฎ๏ผŒ่ฏท็กฎไฟๆ‚จๅทฒ็ป้ตๅพชไบ†ๆˆ‘ไปฌ็š„่ดก็ŒฎๆŒ‡ๅ—๏ผŒๆˆ‘ไปฌไผšๅฐฝๅฟซๅฎกๆŸฅๅฎƒใ€‚
ๅฆ‚ๆžœๆ‚จ้‡ๅˆฐไปปไฝ•้—ฎ้ข˜๏ผŒ่ฏท้šๆ—ถไธŽๆˆ‘ไปฌ่”็ณปใ€‚

@dosubot dosubot bot added the ๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ label Feb 16, 2025
};

if (endpoint) {
console.log('endpoint', endpoint);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove log

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment, the log has been removed

Copy link

codecov bot commented Mar 9, 2025 โ€ข

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.34%. Comparing base (541f275) to head (1fd34bf).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/libs/agent-runtime/bedrock/index.ts 83.33% 3 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6215      +/-   ##
==========================================
- Coverage   91.34%   91.34%   -0.01%     
==========================================
  Files         728      728              
  Lines       68362    68387      +25     
  Branches     4597     3304    -1293     
==========================================
+ Hits        62448    62470      +22     
- Misses       5914     5917       +3     
Flag Coverage ฮ”
app 91.34% <90.00%> (-0.01%) โฌ‡๏ธ
server 97.57% <รธ> (รธ)

Flags with carried forward coverage won't be shown. Click here to find out more.

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

๐Ÿš€ New features to boost your workflow:
  • โ„ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ๐Ÿ“ฆ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒ  Feature Request New feature or request | ็‰นๆ€งไธŽๅปบ่ฎฎ size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants