-
-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix wechat login error: make next-auth compatible for text/plain response type #6585
base: main
Are you sure you want to change the base?
Conversation
@xiangnanscu is attempting to deploy a commit to the LobeChat Desktop Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6585 +/- ##
=======================================
Coverage 91.61% 91.61%
=======================================
Files 699 699
Lines 65856 65856
Branches 4659 4659
=======================================
Hits 60336 60336
Misses 5520 5520
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
我看 https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/providers/wechat.ts#L104-L117 这里已经有了。为啥还需要在 LobeChat 里加一道? |
I've seen https://github.com/nextauthjs/next-auth/blob/main/packages/core/src/providers/wechat.ts#L104-L117 already available here. Why do you still need to add a bun in LobeChat? |
@arvinxx 为了修复无法使用微信扫码登录的问题.见: |
@xiangnanscu 如果 next-auth 合并了是不是不需要我们这边再加了? |
@xiangnanscu If next-auth is merged, do we need to add it here? |
@arvinxx 那边速度太慢了. 而且那个PR没有处理style, 登录的时候不会显示微信图标, 很丑 |
@arvinxx's speed is too slow. And that PR does not process style, and the WeChat icon will not be displayed when logging in, which is very ugly |
@@ -9,7 +9,7 @@ const provider = { | |||
clientId: process.env.AUTH_WECHAT_ID, | |||
clientSecret: process.env.AUTH_WECHAT_SECRET, | |||
platformType: 'WebsiteApp', | |||
profile: (profile) => { | |||
profile: (profile: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 Profile 是可以配置 type 的,不用指定成 any,你看看是不是没配置?
另外需要补一个演示视频,看下整个流程是什么样的。 |
In addition, you need to add a demonstration video to see what the entire process looks like. |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
fix as discussed in #6131
📝 补充信息 | Additional Information