Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛fix: customize logo not display in About page and update DOCS about "deploymentName" #6732

Merged
merged 13 commits into from
Mar 11, 2025

Conversation

bbbugg
Copy link
Contributor

@bbbugg bbbugg commented Mar 5, 2025

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  1. Fix customize logo not display in About page. Previously, custom icons were not displayed.
  2. Updates to Documentation: model-provider (Chinese and English): Added description for the new environment variable DEEPSEEK_MODEL_LIST and QWEN_PROXY_URL. These variables existed previously but were not documented. Corrected the spelling of "deplymentName" to "deploymentName".
  3. Updates to Documentation: model-list (Chinese and English): Added the deploymentName parameter. This parameter existed previously but was not documented. It is required for model providers like Azure, Doubao, and Volcengine (fix [Docs] Feedback for self-hosting/advanced/model-list #6469).

📝 补充信息 | Additional Information

Fix customize logo not display in About page. Previously, custom icons were not displayed.
Copy link

vercel bot commented Mar 5, 2025

@bbbugg is attempting to deploy a commit to the LobeChat Desktop Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 5, 2025
@lobehubbot
Copy link
Member

👍 @bbbugg

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

@dosubot dosubot bot added the 🐛 Bug Something isn't working | 缺陷 label Mar 5, 2025
@bbbugg
Copy link
Contributor Author

bbbugg commented Mar 5, 2025

之前的话是这样,没有img标签
6037af40-d81b-4753-a467-96d0aa07ad88

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


That's what happened before, there is no img tag
6037af40-d81b-4753-a467-96d0aa07ad88

@bbbugg
Copy link
Contributor Author

bbbugg commented Mar 6, 2025

我测试过了,加上“type={'flat'}”参数,无论ProductLogo返回CustomLogo还是LobeChat都能够正常显示。 @arvinxx

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


I have tested it and added the "type={'flat'}" parameter, and it can be displayed normally whether ProductLogo returns CustomLogo or LobeChat. @arvinxx

@bbbugg bbbugg changed the title fix: customize logo not display in About page 🐛fix: customize logo not display in About page Mar 7, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Mar 7, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Mar 7, 2025
@bbbugg
Copy link
Contributor Author

bbbugg commented Mar 7, 2025

更新了文档中的内容:

  1. model-provider(中英文):新加 "DEEPSEEK_MODEL_LIST" 环境变量描述,之前已存在但文档中没写;并修正"deplymentName"单词拼写,改为"deploymentName"。
  2. model-list(中英文):新加 "deploymentName" 参数,之前已存在但文档中没写,例如azure、doubao、volcengine这些需要DeploymentName的模型服务商([Docs] Feedback for self-hosting/advanced/model-list #6469)

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Updated content in the document:

  1. model-provider (Chinese and English): Added the "DEEPSEEK_MODEL_LIST" environment variable description, which has existed before but was not written in the document; and corrected the spelling of the word "deplymentName" and changed to "deploymentName".
  2. model-list (Chinese and English): Add the "deploymentName" parameter, which has existed before but was not written in the document, such as azure, doubao, volcengine, and other model service providers that require DeploymentName ([Docs] Feedback for self-hosting/advanced/model-list #6469)

@bbbugg bbbugg changed the title 🐛fix: customize logo not display in About page 🐛fix: customize logo not display in About page and update DOCS about "deploymentName" Mar 7, 2025
Copy link

vercel bot commented Mar 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 9, 2025 7:26pm

@arvinxx
Copy link
Contributor

arvinxx commented Mar 8, 2025

image

正常是有的,你是不是 .top 域名?

@bbbugg
Copy link
Contributor Author

bbbugg commented Mar 8, 2025

image 正常是有的,你是不是 .top 域名?

不是top域名,我意思是如果自定义了Logo的话,就不显示了
在调用CustomLogo的时候不传type参数,返回不了Logo图标

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


image Normally, are you a .top domain name?

It's not the top domain name, I mean if you customize the logo, it won't be displayed.

@arvinxx
Copy link
Contributor

arvinxx commented Mar 8, 2025

我意思是如果自定义了Logo的话,就不显示了
在调用CustomLogo的时候不传type参数,返回不了Logo图标

那应该解决的问题是 CustomLogo 下的展示,不应该要求 type=flat 。flat 样式不是预期中的

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


I mean if you customize the logo, it won't show it
When calling CustomLogo, the type parameter is not passed, and the Logo icon cannot be returned.

The problem that should be solved is the display under CustomLogo, and type=flat should not be required. The flat style is not expected

@bbbugg
Copy link
Contributor Author

bbbugg commented Mar 8, 2025

我意思是如果自定义了Logo的话,就不显示了
在调用CustomLogo的时候不传type参数,返回不了Logo图标

那应该解决的问题是 CustomLogo 下的展示,不应该要求 type=flat 。flat 样式不是预期中的

CustomLogo 里加了 switch (type) 的默认处理,不加 type=flat 也可以展示了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


I mean if you customize the logo, it won't show it
When calling CustomLogo, the type parameter is not passed, and the Logo icon cannot be returned

The problem that should be solved is the display under CustomLogo, and type=flat should not be required. The flat style is not expected

CustomLogo has added the default processing of switch (type) and can be displayed without type=flat.

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (f284c25) to head (1841fee).
Report is 34 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6732    +/-   ##
========================================
  Coverage   91.34%   91.34%            
========================================
  Files         729      729            
  Lines       68673    68673            
  Branches     4840     4640   -200     
========================================
  Hits        62728    62728            
  Misses       5945     5945            
Flag Coverage Δ
app 91.34% <ø> (ø)
server 97.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arvinxx arvinxx merged commit a3099cf into lobehub:main Mar 11, 2025
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Feedback for self-hosting/advanced/model-list
3 participants