Achievements metrics shows (Unexpected Error)

[orsnaro]

Discussed in #1478

^{Originally posted by orsnaro July 11, 2023}

metrics code in my metrics_action.yml

[LuanRoger]

Same here.
The log does not help so much, it's just this that shows up:

...
  metrics/compute/plugins > achievements > setup found (?)
  metrics/compute/plugins > achievements > setup found (?)
  metrics/compute/plugins > achievements > setup found (?)
...

Usign the debug: yes flag.

This was thrown soo many times, probably because the auto-retry. I cancel the action execution after 7 min.

[redlinejoes]

I also see the issue: "Unexpected error"
I see this in the achievements workflow

  [
    {
      name: 'achievements',
      result: {
        error: {
          message: 'Unexpected error',
          instance: 'Failed to initiate total for achievement plugin'
        }
      }
    }
  ]

[TonyCrane]

GitHub have added a home page to GitHub Search, so metrics can't get total repository/user/issue number from https://github.com/search.

And the query string can't be empty, so maybe we can try searching created:>2007, although this may be not exact, but at least it works.

      for (let i = 0; (i < 100) && ((!total.users) || (!total.repositories)); i++) {
        const page = await browser.newPage()
        await page.goto("https://github.com/search?q=+created%3A%3E2007")
        const totalres = await page.evaluate(() => [...[...document.querySelectorAll("h2")].filter(node => /Filter by/.test(node.innerText)).shift()?.nextSibling?.innerText.trim().matchAll(/(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g) ?? []]) ?? null
        for (const result of totalres) {
          const type = result[1]?.toLowerCase()
          console.debug(`metrics/compute/plugins > achievements > setup found ${type ?? "(?)"}`)
          const count = result[2] ?? ""
          if ((count !== "") && (!total[type])) {
            total[type] = Number(count) * 10e5
            console.debug(`metrics/compute/plugins > achievements > set total.${type} to ${total[type]}`)
          }
        }
        await page.close()
        await imports.wait(10 * Math.random())
      }

[X-itachi-X]

GitHub have added a home page to GitHub Search, so metrics can't get total repository/user/issue number from https://github.com/search.

And the query string can't be empty, so maybe we can try searching created:>2007, although this may be not exact, but at least it works.

      for (let i = 0; (i < 100) && ((!total.users) || (!total.repositories)); i++) {
        const page = await browser.newPage()
        await page.goto("https://github.com/search?q=+created%3A%3E2007")
        const totalres = await page.evaluate(() => [...[...document.querySelectorAll("h2")].filter(node => /Filter by/.test(node.innerText)).shift()?.nextSibling?.innerText.trim().matchAll(/(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g) ?? []]) ?? null
        for (const result of totalres) {
          const type = result[1]?.toLowerCase()
          console.debug(`metrics/compute/plugins > achievements > setup found ${type ?? "(?)"}`)
          const count = result[2] ?? ""
          if ((count !== "") && (!total[type])) {
            total[type] = Number(count) * 10e5
            console.debug(`metrics/compute/plugins > achievements > set total.${type} to ${total[type]}`)
          }
        }
        await page.close()
        await imports.wait(10 * Math.random())
      }

can you explain please what I have to do to make it work?

[orsnaro]

GitHub have added a home page to GitHub Search, so metrics can't get total repository/user/issue number from https://github.com/search.
And the query string can't be empty, so maybe we can try searching created:>2007, although this may be not exact, but at least it works.

      for (let i = 0; (i < 100) && ((!total.users) || (!total.repositories)); i++) {
        const page = await browser.newPage()
        await page.goto("https://github.com/search?q=+created%3A%3E2007")
        const totalres = await page.evaluate(() => [...[...document.querySelectorAll("h2")].filter(node => /Filter by/.test(node.innerText)).shift()?.nextSibling?.innerText.trim().matchAll(/(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g) ?? []]) ?? null
        for (const result of totalres) {
          const type = result[1]?.toLowerCase()
          console.debug(`metrics/compute/plugins > achievements > setup found ${type ?? "(?)"}`)
          const count = result[2] ?? ""
          if ((count !== "") && (!total[type])) {
            total[type] = Number(count) * 10e5
            console.debug(`metrics/compute/plugins > achievements > set total.${type} to ${total[type]}`)
          }
        }
        await page.close()
        await imports.wait(10 * Math.random())
      }

can you explain please what I have to do to make it work?

@X-itachi-X probably says to edit the http here index.mjs : line 85

[JohnyP36]

I have the same problem and disabling the workflow and then enabling it again does not work.

The error in the action is as follows:

Can someone see what's wrong here and explain this?

details

Rendering                                                       │  
1 error(s) occurred
  [
  Status                                                          │ complete
    {
  MIME type                                                       │ image/svg+xml
      name: 'achievements',
      result: {
  ────────────────────────────────────────────────────────────────────────────────────────
  Saving                                                          │  
  Output condition                                                │ always
  Save to /metrics_renders/.github/src/metrics.plugin.achievements.compact.svg │ ok
  Output action                                                   │ commit
        error: {
          message: 'Unexpected error',
          instance: 'Failed to initiate total for achievement plugin'
        }
      }
    }
  ]
Current render sha                                              │ fa44788002fed81464296f2c6203928f8fd7648d
Commit to branch main                                           │ (no changes)

[redlinejoes]

Your question has been answered already, but you have to read the full contents of the issue. I will copy the direct link to make it easier for you to read.

#1479 (comment)

[JohnyP36]

Your question has been answered already, but you have to read the full contents of the issue. I will copy the direct link to make it easier for you to read.

#1479 (comment)

Thanks. But this means the problem is not on my side but with metrics? If yes, thank you for the fix in advance.

[redlinejoes]

GitHub have added a home page to GitHub Search, so metrics can't get total repository/user/issue number from https://github.com/search.
And the query string can't be empty, so maybe we can try searching created:>2007, although this may be not exact, but at least it works.

      for (let i = 0; (i < 100) && ((!total.users) || (!total.repositories)); i++) {
        const page = await browser.newPage()
        await page.goto("https://github.com/search?q=+created%3A%3E2007")
        const totalres = await page.evaluate(() => [...[...document.querySelectorAll("h2")].filter(node => /Filter by/.test(node.innerText)).shift()?.nextSibling?.innerText.trim().matchAll(/(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g) ?? []]) ?? null
        for (const result of totalres) {
          const type = result[1]?.toLowerCase()
          console.debug(`metrics/compute/plugins > achievements > setup found ${type ?? "(?)"}`)
          const count = result[2] ?? ""
          if ((count !== "") && (!total[type])) {
            total[type] = Number(count) * 10e5
            console.debug(`metrics/compute/plugins > achievements > set total.${type} to ${total[type]}`)
          }
        }
        await page.close()
        await imports.wait(10 * Math.random())
      }

can you explain please what I have to do to make it work?

@X-itachi-X probably says to edit the http here index.mjs : line 85

It is more than line#85.
I tried just to replace line#85, and it failed because you need to replace all the different code and then it will work.
See my new profile page, for example https://github.com/redlinejoes

[redlinejoes]

GitHub have added a home page to GitHub Search, so metrics can't get total repository/user/issue number from https://github.com/search.

And the query string can't be empty, so maybe we can try searching created:>2007, although this may be not exact, but at least it works.

      for (let i = 0; (i < 100) && ((!total.users) || (!total.repositories)); i++) {
        const page = await browser.newPage()
        await page.goto("https://github.com/search?q=+created%3A%3E2007")
        const totalres = await page.evaluate(() => [...[...document.querySelectorAll("h2")].filter(node => /Filter by/.test(node.innerText)).shift()?.nextSibling?.innerText.trim().matchAll(/(?<type>Repositories|Users|Issues)\n(?<count>.*?)M/g) ?? []]) ?? null
        for (const result of totalres) {
          const type = result[1]?.toLowerCase()
          console.debug(`metrics/compute/plugins > achievements > setup found ${type ?? "(?)"}`)
          const count = result[2] ?? ""
          if ((count !== "") && (!total[type])) {
            total[type] = Number(count) * 10e5
            console.debug(`metrics/compute/plugins > achievements > set total.${type} to ${total[type]}`)
          }
        }
        await page.close()
        await imports.wait(10 * Math.random())
      }

I have tested and implemented your code, and it works as expected. Thank you for your contribution!

[TonyCrane]

Yes, you can view the complete changes in TonyCrane@46f3272.

But seems this repo haven't updated for a few months, and my last pull request is ignored and closed by robot, so I haven't open a PR for this (also I don't think my solution is the best).

But I think we should repair this? So what do you think @lowlighter ?

[lowlighter]

@TonyCrane I tested your patch locally and it works as expected. I think the workaround is good enough for now so I merged it into master 👍

I guess now we could use the Search API directly by passing your query into it and be more reliable and faster, instead of using puppeteer as it could break again in a future redesign

[obfuscatedgenerated]

I'm fairly certain this bug is causing Actions builds to hang for 10 minutes or more looking at the timing of this issue and my logs:

It's probably a good idea to get the fix into a published GitHub release as soon as possible so it doesn't burn through everyone's actions minutes (since most use lowlighter/metrics@latest as advised in the setup)

[redlinejoes]

I'm fairly certain this bug is causing Actions builds to hang for 10 minutes or more looking at the timing of this issue and my logs:

It's probably a good idea to get the fix into a published GitHub release as soon as possible so it doesn't burn through everyone's actions minutes (since most use lowlighter/metrics@latest as advised in the setup)

My actions jumped to over 11 minutes because of this issue. If you implement the changes outlined in this thread it will run faster again. Make sure to change the year to capture pre-2007 content if you have any. That is referenced in this thread too.

[AjaniBilby]

This issue is closed and it looks like a PR has been merged solving this issue...
But I'm still getting it 🤔

[RSickenberg]

Still the issue with the latest version.

[TonyCrane]

After this pr is merged, there is no new release, so @latest is still an old version. If you want to use the repaired version, you need to use @master.