Communication: Show send button within markdown editor only in communication
#10427
Conversation
github-actions
bot
added
the
client
WalkthroughThis pull request updates the MarkdownEditorMonacoComponent by introducing a new boolean input property, Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as MarkdownEditorMonacoComponent
U->>C: Request editor rendering
C->>C: Check (editType() !== EditType.UPDATE)
C->>C: Check isInCommunication()
alt Both conditions true
C->>U: Render send button
else Any condition false
C->>U: Do not render send button
end
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (3)
🧰 Additional context used📓 Path-based instructions (2)`src/main/webapp/**/*.html`: @if and @for are new and valid ...
`src/main/webapp/**/*.ts`: angular_style:https://angular.io/...
⏰ Context from checks skipped due to timeout of 90000ms (7)
🔇 Additional comments (4)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
…hin-mark-down-editor-only-in-communication
rabeatwork
changed the title
Bugfix: Show send button within markdown editor only in communicationCommunication: Show send button within markdown editor only in communication
I see your point, but here it’s just about hiding/displaying a send button. Duplicating the whole editor for that would be overkill. Using @input() (or signal inputs) for such things is also pretty common and keeps everything reusable and clean. |
|
To me this screams for inheritance which apparently is a thing in Angular . But I'm not an UI-Expert 😄 |
|
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
krusche
deleted the
bugfix/communication/show-send-button-within-mark-down-editor-only-in-communication
branch
Checklist
General
Client
Motivation and Context
The send button below the markdown editor was mistakenly displayed in other areas outside the communication module, such as in programming exercises where the markdown editor is used, too. However, in these cases, the button does not make sense for the user.
Description
The send button is now conditionally displayed depending on whether the markdown editor is embedded within the communication module or not.
Steps for Testing
Prerequisites:
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
Before:
After:
Summary by CodeRabbit