Lectures: Add spacing between categories and correct alignment

[laxerhd]

Opening this PR from a branch in the main repository to enable test server deployment, as it wasn't possible with the previous PR from a forked repository (see #9860), and reopening again because the last PR was open for too long #10081.

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Client

• I strictly followed the client coding and design guidelines.
• Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.

Changes affecting Programming Exercises

• High priority: I tested all changes and their related features with all corresponding user types on a test server configured with the integrated lifecycle setup (LocalVC and LocalCI).
• I tested all changes and their related features with all corresponding user types on a test server configured with Gitlab and Jenkins.

Motivation and Context

The missing spaces between the categories/tags didn't look natural.
The offset also bothered me. Fixes #9857.

Description

I've added some space between the categories and fixed the misalignment of the them.

Steps for Testing

Prerequisites:

• 1 Lecture with embedded programming exercise unit
• Select some categories and difficulty for the exercise

1. Log in to Artemis
2. Navigate to Course -> Lecture
3. Take a look at the categories

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Performance Review

• I (as a reviewer) confirm that the client changes (in particular related to REST calls and UI responsiveness) are implemented with a very good performance even for very large courses with more than 2000 students.
• I (as a reviewer) confirm that the server changes (in particular related to database calls) are implemented with a very good performance even for very large courses with more than 2000 students.

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Exam Mode Test

• Test 1
• Test 2

Performance Tests

• Test 1
• Test 2

Test Coverage

Screenshots

Before:

After:

Summary by CodeRabbit

• Style
  • Updated header styling by shifting from element-based to class-based selectors.
  • Adjusted spacing by increasing the top margin to enhance layout consistency.

[AjayvirS]

Tested locally and code LGTM

[github-actions]

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

[coderabbitai]

Walkthrough

This change modifies the CSS in the exercise categories component. The CSS selector was updated from targeting the <h4> element directly to a class selector .h4. Additionally, the margin styling was adjusted by replacing margin-bottom with margin-top and increasing the margin values from 0.25rem to 0.4rem.

Changes

File(s)	Change Summary
src/.../exercise-categories.component.scss	Updated CSS: selector changed from h4 to .h4; replaced margin-bottom with margin-top and increased margin from 0.25rem to 0.4rem.

Possibly related PRs

• Lectures: Add spacing between categories and correct alignment #10081: Involved similar code-level CSS selector modifications for h4, indicating a direct relation in handling CSS adjustments.

Suggested labels

bugfix

Suggested reviewers

• BBesrour
• EneaGore

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93eba08 and 62d5287.

📒 Files selected for processing (1)

• src/main/webapp/app/shared/exercise-categories/exercise-categories.component.scss (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Codacy Static Code Analysis

🔇 Additional comments (2)

src/main/webapp/app/shared/exercise-categories/exercise-categories.component.scss (2)

1-1: Selector Update: Switching to a Class-based Approach

Changing the selector from targeting an HTML element to using a class (.h4) increases modularity and control over styling. Please ensure that the corresponding HTML elements are updated to include this class so that the styles are applied as expected.

---

2-3: Margin Adjustments for Improved Spacing

The updated margins (using margin-top: 0.4rem; and margin-right: 0.4rem;) align with the PR objective to add more spacing and correct alignment between categories. Verify that these new values render well across various devices and viewports to maintain a consistent layout.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.