Development: Fix failing exam announcements playwright test

[SimonEntholzer]

Checklist

General

• I tested all changes and their related features with all corresponding user types on a test server.
• This is a small issue that I tested locally and was confirmed by another developer on a test server.
• Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
• I chose a title conforming to the naming conventions for pull requests.

Motivation and Context

The test expects the the author of the event to be a specific user. Due to the change in cc09e99, this no longer works for the problem statement changed notification, as it is triggered by the system itself, when the instructor changes the problem statement.

Description

Fixes the test, by expecting the author to be 'system'.

Steps for Testing

Prerequisites:
Run all playwright tests locally and make sure all pass, especially the one which failed: https://bamboo.ase.in.tum.de/browse/ARTEMIS-AEPTMA-DA-909/test/case/783743868

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

• Code Review 1
• Code Review 2

Manual Tests

• Test 1
• Test 2

Summary by CodeRabbit

• Bug Fixes
  • Adjusted the exam update notification so that it now displays “system” as the credited author instead of the instructor. This change provides clearer and more accurate information for exam participants during update notifications.

[coderabbitai]

Walkthrough

The change modifies a single line within the exam participation test. The test now checks that the modal dialog attributes an exercise update to "system" instead of the instructor’s username, reflecting a shift in how authorship is displayed during the exam process.

Changes

File	Change Summary
src/.../ExamParticipation.spec.ts	Updated modal dialog check: changed author verification from instructor’s username to "system"

Possibly related PRs

• Development: Add e2e playwright tests for exam announcement #8630: Modifies the exam participation test file affecting modal dialogs.
• Development: Add exercise update announcement e2e tests #9784: Enhances tests for exercise update notifications, specifically addressing modal dialog author displays.

Suggested labels

tests, ready for review, playwright, bugfix

Suggested reviewers

• coolchock
• krusche
• HanyangXu0508

---

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93eba08 and 4dd5772.

📒 Files selected for processing (1)

• src/test/playwright/e2e/exam/ExamParticipation.spec.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (7)

• GitHub Check: Call Build Workflow / Build .war artifact
• GitHub Check: Call Build Workflow / Build and Push Docker Image
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: client-tests
• GitHub Check: server-style
• GitHub Check: server-tests
• GitHub Check: Analyse

🔇 Additional comments (1)

src/test/playwright/e2e/exam/ExamParticipation.spec.ts (1)

399-399: Simple author expectation update aligned with system behavior.

The change correctly updates the test to expect 'system' as the author of problem statement update notifications rather than the instructor's username. This aligns with the described changes to the notification system where problem statement updates are now triggered by the system itself rather than attributed to a specific user.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[AjayvirS]

Tested locally, the updated test works as intended.

[MaximilianAnzinger]

thx for resolving this 👍

[coolchock]

this is not the right way to fix it. This issue was already solved in scope of this PR: #10422

If you want to resolve the issue ASAP, please just remove @Async from public void createAndSendProblemStatementUpdateEvent

[coolchock]

see my comment

[krusche]

The name should not be system, instead there should be no name displayed!