-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Programming exercises
: Improve integration of Monaco code editor and Athena Preliminary Feedback
#10442
base: feature/programming-exercises/choose-preliminary-feedback-model
Are you sure you want to change the base?
Conversation
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor # Conflicts: # src/main/java/de/tum/cit/aet/artemis/programming/service/ProgrammingExerciseCodeReviewFeedbackService.java # src/main/webapp/app/exercises/programming/participate/code-editor-student-container.component.html # src/main/webapp/app/exercises/programming/participate/code-editor-student-container.component.ts # src/main/webapp/app/exercises/shared/result/updating-result.component.ts
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
…g-exercises/athena-feedback-in-code-editor # Conflicts: # src/main/webapp/app/exercises/modeling/manage/modeling-exercise.module.ts # src/main/webapp/app/exercises/programming/assess/code-editor-tutor-assessment-inline-feedback.component.ts # src/main/webapp/app/exercises/programming/shared/code-editor/container/code-editor-container.component.ts # src/main/webapp/app/exercises/programming/shared/code-editor/file-browser/code-editor-file-browser-node.component.ts # src/main/webapp/app/exercises/programming/shared/lifecycle/programming-exercise-lifecycle.module.ts # src/main/webapp/app/exercises/shared/feedback-suggestion/exercise-feedback-suggestion-options.component.ts # src/main/webapp/app/exercises/text/manage/text-exercise/text-exercise.module.ts # src/main/webapp/app/overview/exercise-details/exercise-details-student-actions.component.html # src/main/webapp/i18n/de/exercise.json # src/test/javascript/spec/component/code-editor/code-editor-file-browser.component.spec.ts # src/test/javascript/spec/component/exercises/shared/feedback/feedback-suggestion-option.component.spec.ts # src/test/javascript/spec/component/modeling-exercise/modeling-exercise-update.component.spec.ts # src/test/javascript/spec/component/overview/exercise-details/exercise-details-student-actions.component.spec.ts # src/test/javascript/spec/component/overview/exercise-details/request-feedback-button/request-feedback-button.component.spec.ts # src/test/javascript/spec/component/programming-assessment/code-editor-tutor-assessment-inline-feedback.component.spec.ts # src/test/javascript/spec/component/programming-exercise/programming-exercise-lifecycle.component.spec.ts # src/test/javascript/spec/component/text-exercise/text-exercise-update.component.spec.ts # src/test/javascript/spec/integration/code-editor/code-editor-container.integration.spec.ts
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor # Conflicts: # src/main/webapp/app/exercises/shared/feedback-suggestion/exercise-feedback-suggestion-options.component.ts # src/main/webapp/app/exercises/shared/preliminary-feedback/exercise-preliminary-feedback-options.component.ts # src/test/javascript/spec/component/overview/exercise-details/exercise-details-student-actions.component.spec.ts # src/test/javascript/spec/component/programming-exercise/programming-exercise-lifecycle.component.spec.ts
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
Programming exercises
: Improve integration of Monaco code editor and Athena Preliminary Feedback
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
…hena-feedback-in-code-editor' into feature/programming-exercises/athena-feedback-in-code-editor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Behavior as described.
Feedback items appear in the editor and icons appear in the file tree.
Multiple feedback items on the same line render correctly.
Items can be reopened from the file tree.
Tested in exam mode. Described features are not visible.
Request feedback button not shown.
File tree has no feedback icons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on TS3. Works as described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…ck-model' into feature/programming-exercises/athena-feedback-in-code-editor
Test only on ts3.
Checklist
General
Client
Motivation and Context
This PR addresses the need for better feedback handling in the code editor for programming exercises. It improves the feedback refresh mechanism and introduces a feature to reopen closed feedback directly from the file tree. These changes enhance usability and provide instructors and students with a more streamlined feedback experience.
Description
This PR introduces enhancements to the feedback management system in the programming exercise code editor. It focuses on improving the user experience when working with feedback items by implementing a feedback refresh mechanism and adding a "Reopen Feedback" button in the file tree. The changes aim to provide a more intuitive and seamless workflow for managing feedback, particularly during active programming assignments.
Steps for Testing
Prerequisites
1 Instructor
1 Student
A programming exercise with feedback enabled.
Testing Feedback Updates in the Programming Editor
Verify that:
Testing in Exam Mode
Verify that:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Exam Mode Test
Performance Tests
Screenshots