Development: Update called endpoints for large course script
#10443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis PR updates several API endpoint URLs by adding new path segments such as Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API_Server
Client->>API_Server: POST /core/admin/courses (course data)
API_Server-->>Client: 400 Error Response
Note right of Client: Cleanup process (run_cleanup) is not invoked
Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
az108
changed the title
Development: Update server urls for large course script Development: Update called endpoints for large course script
jfr2102
approved these changes
Mar 6, 2025
krusche
approved these changes
Mar 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Motivation and Context
After the following PR (#10416) was merged, server URLs received a module-specific prefix. As a result, the large course script stopped working because it relies on calling endpoints on the server. Therefore, it is necessary to update these endpoints in the script.
Additionally, for developers who may not be familiar with the script, getting started could be challenging. To address this, the configuration file has been updated to be more user-friendly.
Description
The endpoints called by the script have been updated accordingly, and the configuration file has been improved with better comments. Furthermore, the run cleanup process has been commented out, as it is rare for developers to run the corresponding randomize script. Without running this script, the cleanup process always results in an error. Instead, a commented-out version of the cleanup is provided, allowing developers to uncomment it if they wish to use the randomize script.
Steps for Testing (This PR can only be tested locally)
Any further description or reminders can be found in the readme which can be found in the supporting_scripts section or in the following PR (#9252).
Prerequisites:
Review Progress
Review Progress
Code Review
Summary by CodeRabbit
New Features
Bug Fixes