-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Fix error with build configuration in exercise creation
#10445
Development
: Fix error with build configuration in exercise creation
#10445
Conversation
WalkthroughThe change updates the Changes
Suggested labels
Suggested reviewers
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`src/main/webapp/**/*.ts`: angular_style:https://angular.io/...
src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Call Build Workflow / Build .war artifact
- GitHub Check: Call Build Workflow / Build and Push Docker Image
- GitHub Check: Codacy Static Code Analysis
- GitHub Check: server-style
- GitHub Check: client-tests
- GitHub Check: server-tests
- GitHub Check: Analyse
🔇 Additional comments (1)
src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts (1)
13-13
:❓ Verification inconclusive
Verify the API endpoint change works end-to-end
To fully validate this fix, please follow the testing steps outlined in the PR objectives: navigate to the exercise creation or editing interface, enable build script customization, and verify that template build scripts are available for editing.
🏁 Script executed:
#!/bin/bash # Search for other occurrences of the incorrect URL pattern to ensure it's not used elsewhere echo "Checking if the incorrect 'paeolus' URL pattern exists elsewhere in the codebase:" rg -i "paeolus" --type tsLength of output: 204
Action Required: Manually Verify API Endpoint Integration
It appears that the outdated URL pattern ("paeolus") is no longer present in the codebase and the endpoint now uses
'api/programming/aeolus'
. However, to ensure this fix works as intended, please manually verify the following:
- Navigate to the exercise creation or editing interface.
- Enable build script customization.
- Confirm that template build scripts are available for editing and behave as expected.
src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, works as expected now! Thanks for fixing.
Checklist
General
Motivation and Context
Fix wrong url.
Steps for Testing
Prerequisites:
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Manual Tests
Screenshots
Before

After

Summary by CodeRabbit