Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Fix error with build configuration in exercise creation #10445

Conversation

BBesrour
Copy link
Member

@BBesrour BBesrour commented Mar 5, 2025

Checklist

General

Motivation and Context

Fix wrong url.

Steps for Testing

Prerequisites:

  • 1 Instructor
  1. Go to create or edit prog exercise
  2. Tick customize buildscript
  3. Make sure that a template build script is provided and that you can edit the env variables and the docker image

Testserver States

You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.

Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Before
image

After
image

Summary by CodeRabbit

  • Bug Fixes
    • Adjusted the service's configuration to ensure proper connectivity, enhancing the reliability of programming features.

@BBesrour BBesrour self-assigned this Mar 5, 2025
@BBesrour BBesrour requested a review from a team as a code owner March 5, 2025 19:38
@github-actions github-actions bot added the client Pull requests that update TypeScript code. (Added Automatically!) label Mar 5, 2025
@BBesrour BBesrour requested a review from ole-ve March 5, 2025 19:38
Copy link

coderabbitai bot commented Mar 5, 2025

Walkthrough

The change updates the AeolusService by modifying the resourceUrl property. The URL has been corrected from 'api/programming/paeolus' to 'api/programming/aeolus'. There are no other modifications to service logic or functionality.

Changes

File Path Change Summary
src/main/webapp/app/.../aeolus.service.ts Updated resourceUrl from 'api/programming/paeolus' to 'api/programming/aeolus' in AeolusService

Suggested labels

bugfix, server, client, ready for review

Suggested reviewers

  • SimonEntholzer
  • HanyangXu0508
  • ole-ve
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93eba08 and effb82f.

📒 Files selected for processing (1)
  • src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
`src/main/webapp/**/*.ts`: angular_style:https://angular.io/...

src/main/webapp/**/*.ts: angular_style:https://angular.io/guide/styleguide;methods_in_html:false;lazy_loading:true;code_reuse:true;tests:meaningful;types:PascalCase;enums:PascalCase;funcs:camelCase;props:camelCase;no_priv_prefix:true;strings:single_quotes;localize:true;btns:functionality;links:navigation;icons_text:newline;labels:associate;code_style:arrow_funcs,curly_braces,open_braces_same_line,indent_4;memory_leak_prevention:true;routes:naming_schema;chart_framework:ngx-charts;responsive_layout:true

  • src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts
⏰ Context from checks skipped due to timeout of 90000ms (7)
  • GitHub Check: Call Build Workflow / Build .war artifact
  • GitHub Check: Call Build Workflow / Build and Push Docker Image
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: server-style
  • GitHub Check: client-tests
  • GitHub Check: server-tests
  • GitHub Check: Analyse
🔇 Additional comments (1)
src/main/webapp/app/exercises/programming/shared/service/aeolus.service.ts (1)

13-13:

❓ Verification inconclusive

Verify the API endpoint change works end-to-end

To fully validate this fix, please follow the testing steps outlined in the PR objectives: navigate to the exercise creation or editing interface, enable build script customization, and verify that template build scripts are available for editing.


🏁 Script executed:

#!/bin/bash
# Search for other occurrences of the incorrect URL pattern to ensure it's not used elsewhere
echo "Checking if the incorrect 'paeolus' URL pattern exists elsewhere in the codebase:"
rg -i "paeolus" --type ts

Length of output: 204


Action Required: Manually Verify API Endpoint Integration

It appears that the outdated URL pattern ("paeolus") is no longer present in the codebase and the endpoint now uses 'api/programming/aeolus'. However, to ensure this fix works as intended, please manually verify the following:

  • Navigate to the exercise creation or editing interface.
  • Enable build script customization.
  • Confirm that template build scripts are available for editing and behave as expected.

Copy link
Contributor

@ole-ve ole-ve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link
Contributor

@coolchock coolchock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code

Copy link
Contributor

@chrisknedl chrisknedl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works as expected now! Thanks for fixing.

@krusche krusche added this to the 8.0 milestone Mar 9, 2025
@krusche krusche merged commit 0ac58c6 into develop Mar 9, 2025
35 of 43 checks passed
@krusche krusche deleted the bugfix/integrated-code-lifecycle/fix-no-options-build-config branch March 9, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix client Pull requests that update TypeScript code. (Added Automatically!) ready to merge
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

7 participants