Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed xyz bug in ConfigurationManager #2492

Open
wants to merge 4 commits into
base: 5.4.0-develop
Choose a base branch
from

Conversation

GiraldoNainggolan
Copy link

This pull request fixes a bug in the ConfigurasiManager module of the Magento 2 PhpStorm plugin. Previously, there was an issue with configuration parsing that caused incorrect processing, preventing proper loading. This update ensures that configurations are correctly parsed and loaded without errors. The changes include fixing the parsing logic, adding validation to ensure the retrieved values meet expectations, and improving code readability. To test this update, install the latest version of the plugin, open PhpStorm, navigate to the plugin settings, and verify that configurations load correctly without errors. Additionally, check the parsing process to ensure it runs smoothly without generating unnecessary logs.

@VitaliyBoyko
Copy link
Contributor

VitaliyBoyko commented Feb 17, 2025

@GiraldoNainggolan please sign the CLA agreement, address test issues, and remove .history/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Review in Progress
Development

Successfully merging this pull request may close these issues.

3 participants