Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Automatically Remove All Desktop Shortcuts' Option #3338

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

mrixner
Copy link
Contributor

@mrixner mrixner commented Feb 21, 2025

  • I have read the contributing guidelines, and I agree with the Code of Conduct.
  • Have you checked that there aren't other open pull requests for the same changes?
  • Have you tested that the committed code can be executed without errors?
  • This PR is not composed of garbage changes used to farm GitHub activity to enter potential Crypto AirDrops.
    Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.

This PR adds an option in the 'manage desktop shortcuts' dialog to automatically delete all desktop shortcuts when they're encountered. It does not delete shortcuts marked to not be deleted in the dialog.


Closes #3321
Closes #3369

@marticliment
Copy link
Owner

Looks good. Will test and merge later

@marticliment
Copy link
Owner

Clicking "Manual Scan" with the new option enabled wipes all shortcuts out of existence.
Please do check all possible risky scenarios before posting a PR

@mrixner mrixner marked this pull request as draft February 26, 2025 19:05
@mrixner mrixner marked this pull request as ready for review March 2, 2025 02:48
Copy link
Owner

@marticliment marticliment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrixner, I think it would make more sense to have two different methods, one to clean up the new shortcuts, and one to delete all shortcuts from the desktop; and then call them whenever they need to be calledd, instead of frankensteininga method that when passed an empty vector will do a thing or another, as this is very confusing and can very easily lead to confusion and chaos (as it already happened).

I think having more simple, do-one-thing-only methods is the way to go, because the code will be more maintainable in the future.

@mrixner mrixner marked this pull request as draft March 8, 2025 23:11
@mrixner
Copy link
Contributor Author

mrixner commented Mar 9, 2025

I was going to try to see if I could fix #3369 as well, but I can no longer build UniGetUI after merging main into the branch.
image
I suspect it has something to do with the Width="*" column definitions not shrinking when the window does or HorizontalAlignment="Stretch" having a similar issue, but I'm not proficient enough in XAML to determine that without a working build.

Everything else works, though, and I tested all the cases I could think of.

@mrixner mrixner marked this pull request as ready for review March 9, 2025 00:18
@marticliment
Copy link
Owner

No, the issue you are seeing is different.
Go to Solution explorer -> Solution items -> Directory.build.props and there change the WindowsSdkVersion from X.X.X.56 to X.X.X.57 or viceversa

@mrixner mrixner requested a review from marticliment March 10, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants