-
-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'Automatically Remove All Desktop Shortcuts' Option #3338
base: main
Are you sure you want to change the base?
Conversation
…n operation, not just new ones
Looks good. Will test and merge later |
Clicking "Manual Scan" with the new option enabled wipes all shortcuts out of existence. |
…e 'RemoveAllDesktopShortcuts' setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrixner, I think it would make more sense to have two different methods, one to clean up the new shortcuts, and one to delete all shortcuts from the desktop; and then call them whenever they need to be calledd, instead of frankensteininga method that when passed an empty vector will do a thing or another, as this is very confusing and can very easily lead to confusion and chaos (as it already happened).
I think having more simple, do-one-thing-only methods is the way to go, because the code will be more maintainable in the future.
…delete all' setting
…xner/UniGetUI into remove-all-desktop-shortcuts
I was going to try to see if I could fix #3369 as well, but I can no longer build UniGetUI after merging main into the branch. Everything else works, though, and I tested all the cases I could think of. |
No, the issue you are seeing is different. |
Remove a warning against behavior that was rectified
Any user suspected of farming GitHub activity with crypto purposes will get banned. Submitting broken code wastes the contributors' time, who have to spend their free time reviewing, fixing, and testing code that does not even compile breaks other features, or does not introduce any useful changes. I appreciate your understanding.
This PR adds an option in the 'manage desktop shortcuts' dialog to automatically delete all desktop shortcuts when they're encountered. It does not delete shortcuts marked to not be deleted in the dialog.
Closes #3321
Closes #3369