Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet-beta feature #6327

Open
arsium opened this issue Feb 25, 2025 · 4 comments
Open

Packet-beta feature #6327

arsium opened this issue Feb 25, 2025 · 4 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request Type: New Diagram

Comments

@arsium
Copy link

arsium commented Feb 25, 2025

Proposal

First, thanks for packet datagram intregration. It is a really nice idea.

I have a suggestion to make things a bit better about long block of bits.

Instead of having repeated block for longer blocks,
Image
Getting something like :

Image

What do you think ?

Use Cases

Extension of packet datagram

Screenshots

No response

Syntax

No response

Implementation

None

@arsium arsium added Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request Type: New Diagram labels Feb 25, 2025
@sidharthv96
Copy link
Member

The packet diagram is meant to give an idea about the structure of a packet.
So, if a packet has a huge data block, it should show the size in the diagram as well, without having the users to check the numbers on each block.
Do you have a use case where the repeated lines are causing issues?
We could potentially add a config which would render the big block into a single row, but that won't be the default behaviour.

@arsium
Copy link
Author

arsium commented Mar 4, 2025

Yes when you have, for example Payload with ARP/Ethernet frame : 46 to 1500
I got so many blocks.

@sidharthv96
Copy link
Member

@arsium then we can add a config to support the feature. 👍

@arsium
Copy link
Author

arsium commented Mar 6, 2025

Thank you 🙏!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Enhancement New feature or request Type: New Diagram
Projects
None yet
Development

No branches or pull requests

2 participants