Fix: Could not find a suitable point for the given distance

[yari-dewalt]

📑 Summary

Fixes an error thrown when calculating points for an edge: Could not find a suitable point for the given distance. This is caused by a division by zero error giving a NaN result for the point due to the vectorDistance between two points being zero (the points are stacked on top of each other) const distanceRatio = remainingDistance / vectorDistance; This is an issue only seen in Mermaid Chart where you can use the fixed layout as the regular layout algorithms won't have points in an edge with a distance of zero in between them.

📏 Design Decisions

If the vectorDistance is zero it will simply return the previous point avoiding errors.

📋 Tasks

Make sure you

• 📖 have read the contribution guidelines
• 💻 have added necessary unit/e2e tests.
• 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
• 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 5447a9f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[netlify]

✅ Deploy Preview for mermaid-js ready!

Name	Link
🔨 Latest commit	5447a9f
🔍 Latest deploy log	https://app.netlify.com/sites/mermaid-js/deploys/67be0ab7e5d5de0008286dec
😎 Deploy Preview	https://deploy-preview-6329--mermaid-js.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[pkg-pr-new]

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6329

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6329

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6329

npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6329

commit: 5447a9f

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 3.88%. Comparing base (60db05b) to head (5447a9f).
Report is 36 commits behind head on develop.

Files with missing lines	Patch %	Lines
packages/mermaid/src/utils.ts	0.00%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           develop   #6329      +/-   ##
==========================================
- Coverage     3.88%   3.88%   -0.01%     
==========================================
  Files          398     398              
  Lines        42040   42043       +3     
  Branches       637     637              
==========================================
  Hits          1634    1634              
- Misses       40406   40409       +3     

Flag	Coverage Δ
unit	3.88% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/mermaid/src/utils.ts	18.08% <0.00%> (-0.10%)	⬇️

[argos-ci]

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build	Status	Details	Updated (UTC)
default (Inspect)	✅ No changes detected	-	Feb 25, 2025, 6:32 PM

[knsv]

LGTM!