Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS: fix promo bar #6331

Merged
merged 2 commits into from
Feb 26, 2025
Merged

DOCS: fix promo bar #6331

merged 2 commits into from
Feb 26, 2025

Conversation

huynhicode
Copy link
Member

📑 Summary

(Base branch set to master.)

This PR contains updates to the promo bar.

Resolves # n/a

📏 Design Decisions

Design decisions made by the Mermaid Chart team.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 510fd0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Feb 26, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 510fd0f
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67bead6dd1ce420008f03119
😎 Deploy Preview https://deploy-preview-6331--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (ce99d96) to head (510fd0f).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
.../mermaid/src/docs/.vitepress/components/TopBar.vue 0.00% 17 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6331      +/-   ##
=========================================
+ Coverage    4.46%   4.49%   +0.03%     
=========================================
  Files         385     382       -3     
  Lines       54352   53988     -364     
  Branches      598     621      +23     
=========================================
  Hits         2425    2425              
+ Misses      51927   51563     -364     
Flag Coverage Δ
unit 4.49% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../mermaid/src/docs/.vitepress/components/TopBar.vue 0.00% <0.00%> (ø)

... and 28 files with indirect coverage changes

@sidharthv96 sidharthv96 merged commit b22103b into master Feb 26, 2025
15 of 21 checks passed
@sidharthv96 sidharthv96 deleted the fix-promo branch February 26, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants