Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/6341 fix symbolic link #6342

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gaurav-chaurasia
Copy link

@gaurav-chaurasia gaurav-chaurasia commented Mar 2, 2025

📑 Summary

Fixed symbolic link for contributing.md by creating hard link
Resolves #6341

📏 Design Decisions

  • This PR replaces the symbolic link for CONTRIBUTING.md with a hard link. With this change, CONTRIBUTING.md now points to the same inode as the target file but with a different name. This ensures consistency, avoids potential issues with broken symbolic links, and improves file access reliability
  • This change ensures that CONTRIBUTING.md always reflects the original content, even if the original file is renamed or relocated within the same filesystem

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 2, 2025

⚠️ No Changeset found

Latest commit: 7a63bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Mar 2, 2025
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7a63bff
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67c4b4e845075800086ba29d
😎 Deploy Preview https://deploy-preview-6342--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6342
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6342
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6342
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6342

commit: 7a63bff

Copy link

codecov bot commented Mar 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.88%. Comparing base (bc2bd3d) to head (7a63bff).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #6342   +/-   ##
=======================================
  Coverage     3.88%   3.88%           
=======================================
  Files          398     398           
  Lines        42044   42044           
  Branches       638     638           
=======================================
  Hits          1635    1635           
  Misses       40409   40409           
Flag Coverage Δ
unit 3.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link

argos-ci bot commented Mar 2, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 2, 2025, 7:53 PM

@gaurav-chaurasia gaurav-chaurasia marked this pull request as draft March 3, 2025 18:13
@gaurav-chaurasia gaurav-chaurasia marked this pull request as ready for review March 3, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken link in https://github.com/briz123/mermaid/blob/develop/CONTRIBUTING.md
1 participant