Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support links in SVGs #6352

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

jeswr
Copy link

@jeswr jeswr commented Mar 4, 2025

📑 Summary

Brief description about the content of your PR.

Complimentary to #6343

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 7e5af3b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
mermaid Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Enhancement New feature or request label Mar 4, 2025
Copy link

netlify bot commented Mar 4, 2025

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 7e5af3b
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/67c704a5fd052000084353e4
😎 Deploy Preview https://deploy-preview-6352--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 4, 2025

Open in Stackblitz

npm i https://pkg.pr.new/mermaid-js/mermaid@6352
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/mermaid-zenuml@6352
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/layout-elk@6352
npm i https://pkg.pr.new/mermaid-js/mermaid/@mermaid-js/parser@6352

commit: 7e5af3b

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 3.88%. Comparing base (bc2bd3d) to head (7e5af3b).

Files with missing lines Patch % Lines
...mermaid/src/rendering-util/handle-markdown-text.ts 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           develop   #6352      +/-   ##
==========================================
- Coverage     3.88%   3.88%   -0.01%     
==========================================
  Files          398     399       +1     
  Lines        42044   42057      +13     
  Branches       638     638              
==========================================
  Hits          1635    1635              
- Misses       40409   40422      +13     
Flag Coverage Δ
unit 3.88% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...mermaid/src/rendering-util/handle-markdown-text.ts 1.28% <0.00%> (-0.04%) ⬇️

... and 1 file with indirect coverage changes

Copy link

argos-ci bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No changes detected - Mar 4, 2025, 2:05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant