Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add a note about DART in early_stopping docstring #6846

Merged
merged 3 commits into from
Mar 4, 2025

Conversation

jameslamb
Copy link
Collaborator

@jameslamb jameslamb commented Feb 28, 2025

fixes #6244

Adds a note about DART boosting disabling early stopping in the callback.early_stopping() docstring, to make that a bit more visible (especially for people running Python with warnings filtered out).

Notes for Reviewers

I activated this branch on readthedocs so we can see how this renders.

build link: https://readthedocs.org/projects/lightgbm/builds/27344381/

@StrikerRUS
Copy link
Collaborator

Maybe add the same note in R docstrings for lightgbm(), lgb.cv() and lgb.train() functions?

#' @section Early Stopping:

@jameslamb
Copy link
Collaborator Author

Sure, good idea! Just pushed 7dfadd1 doing that.

Here's how it renders locally for me in ?lightgbm::lgb.train.

Screenshot 2025-03-02 at 8 24 24 PM

@jameslamb jameslamb changed the title [python-package] add a note about DART in early_stopping docstring [docs] add a note about DART in early_stopping docstring Mar 3, 2025
Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks a lot for this clarification note!

@StrikerRUS StrikerRUS merged commit 6437645 into master Mar 4, 2025
49 checks passed
@StrikerRUS StrikerRUS deleted the docs/dart-early-stopping branch March 4, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[python-package] Early Stopping does not work in LGBMClassifier
2 participants