[R-package] Handling NULL objective when booster prints, adding tests #6850
+89
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s out of method tests, creating unique tests for different method situations
walkerjameschris
requested review from
guolinke,
jameslamb,
shiyu1994,
jmoralez,
borchero and
StrikerRUS
as code owners
walkerjameschris
changed the title
walkerjameschris
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #6848
This PR fixes an issue where
lgb.train()creates a booster, the booster is printed, and no objective is specified. This led to an error due to aNULLvalue. I have handled this by extracting the default objective (looks to bel2) and printing that in the event a built-in or custom objective is not provided.