[BUG]: Invalid MIDI 1.0 iJack string indexes can crash USB MIDI 2.0 driver when building GTBs

[AmeNote-Michael]

Windows Version

Canary 27802

Service Installation Method

GitHub

SDK version, if appropriate

Customer Preview 2

Location

Windows MIDI Services Console App

Type of bug

Application Crash

Steps to reproduce

1. Plug in to available USB port X6 from MIDIPlus (or some other devices)
2. Use device manager to update driver to USB MIDI 2.0 driver
3. In console run "midi endpoint monitor"

Expected behavior

Able to select device from list to monitor.

Additional notes

MIDI Console app appears to hang and never present list. You have to kill the console terminal window to exit. In some cases can cause green screen.

This issue was found and reported originally by @AmeNote-MikeKent by email.

[AmeNote-Michael]

Usind debugger it was discovered that the building of group terminal blocks in case of USB MIDI 1.0 device was not incrementing the number of group terminal blocks due to the X6 USB Descriptor having an error in pointing to an invalid String Descriptor.

The driver handled the invalid string descriptor as a warning, but did not properly increment number of group terminal blocks.

[AmeNote-Michael]

Descriptor dump shows invalid string indexes.

DescriptorDump_X6III.txt

[AmeNote-Michael]

@Psychlist1972 resolved in Pull Request #578

[Psychlist1972]

You need to restart the service after changing the driver associated with a device. The service doesn't get a good notification that the driver has changed.

Related #403
Duplicate: #483

[AmeNote-Michael]

@Psychlist1972 this is not same thing - there was a bug in driver. There is a pull request related to this bug.