Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Move optional MlosCoreOptimizer config elements into a "config" section as others do #957

Open
bpkroth opened this issue Feb 25, 2025 · 1 comment
Labels

Comments

@bpkroth
Copy link
Contributor

bpkroth commented Feb 25, 2025

Nearly all other configs follow the form:

{
    "class": "class.name",
    "config": {
        ...
    }
}

The optimizer json schema intermingles a few things though:

{
    "class": "mlos_bench.optimizers.MlosCoreOptimizer",
    "config": {
        "optimizer_type": "SMAC",
        "n_random_init": 10 // <-- this isn't valid if optimizer_type is "FLAML"
    }
}

Instead it should really be:

{
    "class": "mlos_bench.optimizers.MlosCoreOptimizer",
    "config": {
        "optimizer_type": "SMAC",
       "optimizer_args": {
            "n_random_init": 10
        }
    }
}

Which is what we do for space_adapter_args for instance.

@bpkroth
Copy link
Contributor Author

bpkroth commented Feb 25, 2025

NOTE: this will be a breaking change and will need a new version cut for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant