Skip to content

Refactor: Move optional MlosCoreOptimizer config elements into a "config" section as others do #957

Open
@bpkroth

Description

@bpkroth

Nearly all other configs follow the form:

{
    "class": "class.name",
    "config": {
        ...
    }
}

The optimizer json schema intermingles a few things though:

{
    "class": "mlos_bench.optimizers.MlosCoreOptimizer",
    "config": {
        "optimizer_type": "SMAC",
        "n_random_init": 10 // <-- this isn't valid if optimizer_type is "FLAML"
    }
}

Instead it should really be:

{
    "class": "mlos_bench.optimizers.MlosCoreOptimizer",
    "config": {
        "optimizer_type": "SMAC",
       "optimizer_args": {
            "n_random_init": 10
        }
    }
}

Which is what we do for space_adapter_args for instance.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions