-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Add localisation for keyboard keys #23700
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
@niels9001 You speak dutch right? I don't get if space in dutch is "Mellemrumstast" (used in Microsoft help articles) or "spatiebalk" (used on Wikipedia). |
I have now idea what Mellemrumstast means... :).. But yeah, should be "Spatiebalk"! |
Ok Thank you! |
|
Technically yes, but I think the translations won't be very reliable
I know, this is still in draft. |
@Aaron-Junker what's the source you are using? You are using Danish in stead of Dutch. Also note the difference between "space" (a character) and "space bar" (the physical thing) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch / Case keywords?
_keyVisual.Style = GetStyleSize("TextKeyVisualStyle"); | ||
_keyVisual._keyPresenter.Content = _keyVisual.Content; | ||
|
||
if (currentLanguage == "de") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look like perfect Switch
conditions
|
||
if (currentLanguage == "de") | ||
{ | ||
if ((string)_keyVisual._keyPresenter.Content == "Ctrl") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for this level
🙈Oh, you're right. I'm so sorry. As I said I used this help article in different languages |
@crutkas I want your opinion on this. Should this be something the localization team should do? |
Hi @Aaron-Junker , |
Answer was these should go through translation service and we should add a comment such as "The string of the "Ctrl" part of the shortcuts in tooltips, (Ex: Ctrl+V)" if we were translating Ctrl |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@jaimecbernardo I reworked everything. There's just one thing that needs to be fixed and I don't know how. The Keyboard Manager Editor is using it's own resource file instead of the PowerToys interop one. |
I see what the problem is with KBM. In theory, it should be possible to include 2 .rc files, although we don't have an example for that in our code. |
I don't even get how the first one is included. I have no idea how I could do this. |
Summary of the Pull Request
Add localisation support to keyboard keys.
PR Checklist
Detailed Description of the Pull Request / Additional comments
To-Do:
Validation Steps Performed