[WIP]Add localisation for keyboard keys

[Aaron-Junker]

Summary of the Pull Request

Add localisation support to keyboard keys.

PR Checklist

• Closes: Add translations for keybindings #9482
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

To-Do:

• Move logic in seperate class
• Make the same for keyboard manager

Validation Steps Performed

[Aaron-Junker]

@niels9001 You speak dutch right? I don't get if space in dutch is "Mellemrumstast" (used in Microsoft help articles) or "spatiebalk" (used on Wikipedia).

[niels9001]

Mellemrumstast

I have now idea what Mellemrumstast means... :)..

But yeah, should be "Spatiebalk"!

[Aaron-Junker]

Mellemrumstast

I have now idea what Mellemrumstast means... :)..

But yeah, should be "Spatiebalk"!

Ok Thank you!

[htcfreek]

@Aaron-Junker

• Can't we use our translation system for that?
• Please check the list of supported langs against our docs page. I think Chinese is missing.

[Aaron-Junker]

@Aaron-Junker

• Can't we use our translation system for that?

Technically yes, but I think the translations won't be very reliable

• Please check the list of supported langs against our docs page. I think Chinese is missing.

I know, this is still in draft.

[Jay-o-Way]

@Aaron-Junker what's the source you are using? You are using Danish in stead of Dutch.

Also note the difference between "space" (a character) and "space bar" (the physical thing)

[Jay-o-Way]

Switch / Case keywords?

[Jay-o-Way]

These look like perfect Switch conditions

[Jay-o-Way]

Same for this level

[Aaron-Junker]

@Aaron-Junker what's the source you are using? You are using Danish in stead of Dutch.

🙈Oh, you're right. I'm so sorry. As I said I used this help article in different languages

[Aaron-Junker]

@crutkas I want your opinion on this. Should this be something the localization team should do?

[jaimecbernardo]

Hi @Aaron-Junker ,
Thanks for opening the PR.
I think the way to doing this would be to rely on Resource files to have the localization team handle it.

[crutkas]

Answer was these should go through translation service and we should add a comment such as "The string of the "Ctrl" part of the shortcuts in tooltips, (Ex: Ctrl+V)" if we were translating Ctrl

[Aaron-Junker]

@jaimecbernardo I reworked everything. There's just one thing that needs to be fixed and I don't know how. The Keyboard Manager Editor is using it's own resource file instead of the PowerToys interop one.

[stefansjfw]

@jaimecbernardo I reworked everything. There's just one thing that needs to be fixed and I don't know how. The Keyboard Manager Editor is using it's own resource file instead of the PowerToys interop one.

I see what the problem is with KBM. In theory, it should be possible to include 2 .rc files, although we don't have an example for that in our code.

[Aaron-Junker]

@jaimecbernardo I reworked everything. There's just one thing that needs to be fixed and I don't know how. The Keyboard Manager Editor is using it's own resource file instead of the PowerToys interop one.

I see what the problem is with KBM. In theory, it should be possible to include 2 .rc files, although we don't have an example for that in our code.

I don't even get how the first one is included. I have no idea how I could do this.