[File Locksmith] Add infobar when not running as admin

[HydroH]

Summary of the Pull Request

PR Checklist

• Closes: [File Locksmith] Show warning bar when not running as admin #21805
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[Jay-o-Way]

Would be extra nice to have a "Restart as admin" button somewhere here :⁠-⁠)

[Jay-o-Way]

Personal opinion: this is still pretty vague, to me.

Suggested change

	<value>Some results might be missing because of insufficient permission. Restart as administrator to see them.</value>
	<value>Run [File Locksmith] with admin rights to see more results.</value>

[HydroH]

This does not contain information about missing results were because of insufficient permissions, maybe make it more clear?

[htcfreek]

Would it make sense to use the text "Some results might be missing because of insufficient permission." and move the restart as admin button to the infobar as text button "Restart as administrator"?

[niels9001]

+1 on @htcfreek 's suggestion. This is consistent with the OS and other PT modules.

[htcfreek]

Would be extra nice to have a "Restart as admin" button somewhere here :⁠-⁠)

It exists in the ui. At the top where the reload button is.

[jaimecbernardo]

Thanks for opening the PR.
I've tried running the PR in both Debug and release, but both are crashing for me when trying to start File Locksmith.

[HydroH]

Thanks for opening the PR. I've tried running the PR in both Debug and release, but both are crashing for me when trying to start File Locksmith.

I can replicate this problem when running from a clean build at the first time, but it does not crash in subsequent runs.
Did a couple of tests, crash happens as long as a Infobar is present.
Seems to be related to this issue: microsoft/microsoft-ui-xaml#7143

[jaimecbernardo]

Thanks for opening the PR. I've tried running the PR in both Debug and release, but both are crashing for me when trying to start File Locksmith.

I can replicate this problem when running from a clean build at the first time, but it does not crash in subsequent runs. Did a couple of tests, crash happens as long as a Infobar is present. Seems to be related to this issue: microsoft/microsoft-ui-xaml#7143

Thank for looking into it.
Seems related, although we're not using the mentioned flags:
IncludeNativeLibrariesForSelfExtract or PublishSingleFile

Definitely can't bring it in if it's causing crashes, though.
Regarding the change itself, can you please share some screenshots? I'm thinking this will look a bit big in the UI.

[HydroH]

Thanks for opening the PR. I've tried running the PR in both Debug and release, but both are crashing for me when trying to start File Locksmith.

I can replicate this problem when running from a clean build at the first time, but it does not crash in subsequent runs. Did a couple of tests, crash happens as long as a Infobar is present. Seems to be related to this issue: microsoft/microsoft-ui-xaml#7143

Thank for looking into it. Seems related, although we're not using the mentioned flags: IncludeNativeLibrariesForSelfExtract or PublishSingleFile

Definitely can't bring it in if it's causing crashes, though. Regarding the change itself, can you please share some screenshots? I'm thinking this will look a bit big in the UI.

This is how it looks currently.

Maybe putting the restart as admin button in the infobar would be better?

[htcfreek]

@HydroH
Yes. Please move the button. But then we should use a text instead of a symbol, I think.

[HydroH]

@HydroH Yes. Please move the button. But then we should use a text instead of a symbol, I think.

Sorry for responding late, I was on a holiday.
This is what it looks like now.

But I think this PR is blocked by the infobar issue at the moment.

[Jay-o-Way]

I know it's kinda late, but I think a Popup control might be even better: you can connect it to the existing restart-as-admin button. And it's just as intrusive as an info bar.

[jaimecbernardo]

I've given it another test with the latest changes. This is still crashing for me on startup of File Locksmith.
The way I test it is by building an installer and running from the context menu. It also crashes when I run directly from "PowerToys\x64\Release\WinUI3Apps\PowerToys.FileLocksmithUI.exe"
/needinfo