File Actions menu

[Aaron-Junker]

Summary of the Pull Request

Adding a new menu invokable by selecting files in explorer and pressing a shortcut set in the settings.

Screenshots

PR Checklist

• Closes: New Folder with Selection #3569 copy/move to folder #139 Generate/Verify checksums from file #57 Explorer right click copy image to clipboard (not file) #5256 Replace filename with checksum #25594 Marking and unlocking locked files from context menu #91 Folder collapse (move all files to root) #9269
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated File Actions Menu dev docs #31668
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: [PowerToys]File actions menu docs MicrosoftDocs/windows-dev-docs#5137

Detailed Description of the Pull Request / Additional comments

Things left to do:

• Add installer
• Add icon
• DPI Awareness

Validation Steps Performed

[Aaron-Junker]

@niels9001 Do you have an idea why the contextmenu doesn't take the WPFUI style?

[github-advanced-security]

check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

[jaimecbernardo]

Code LGTM!
Regarding changes I think we're still missing:
1 - Save file as acts as a "Move to" when there's a conflict and you select "Replace" and as a "Copy to" when there's no conflict. I assume the intended is acting as a "Copy to" everytime?
2 - It's crashing for me when I try to use it on some link files. One example is the shortcut .lnk file for "OBS Studio".
3 - The default Ctrl+Alt+A hotkey will likely conflict with Alt Gr+A on some keyboards. I advise making the default shortcut Ctrl+Win+Alt+A or disable the module by default.
4 - New telemetry needs to be added into "DATA_AND_PRIVACY.md".

In the meanwhile, I've merged latest main, added the "New" badge in Settings and tweaked gpo and spellcheck a bit.

[jaimecbernardo]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Aaron-Junker]

Code LGTM! Regarding changes I think we're still missing: 1 - Save file as acts as a "Move to" when there's a conflict and you select "Replace" and as a "Copy to" when there's no conflict. I assume the intended is acting as a "Copy to" everytime? 2 - It's crashing for me when I try to use it on some link files. One example is the shortcut .lnk file for "OBS Studio". 3 - The default Ctrl+Alt+A hotkey will likely conflict with Alt Gr+A on some keyboards. I advise making the default shortcut Ctrl+Win+Alt+A or disable the module by default. 4 - New telemetry needs to be added into "DATA_AND_PRIVACY.md".

In the meanwhile, I've merged latest main, added the "New" badge in Settings and tweaked gpo and spellcheck a bit.

1. Yes, this is a mistake. I fixed it
2. Don't know why this is happening, but atleast it is not crashing anymore now.
3. I don't think your proposed idea would be easy to press. So I switched it to Ctrl+Shift+A
4. I added them

Thanks again for your review.

[stefansjfw]

Code LGTM! Regarding changes I think we're still missing: 1 - Save file as acts as a "Move to" when there's a conflict and you select "Replace" and as a "Copy to" when there's no conflict. I assume the intended is acting as a "Copy to" everytime? 2 - It's crashing for me when I try to use it on some link files. One example is the shortcut .lnk file for "OBS Studio". 3 - The default Ctrl+Alt+A hotkey will likely conflict with Alt Gr+A on some keyboards. I advise making the default shortcut Ctrl+Win+Alt+A or disable the module by default. 4 - New telemetry needs to be added into "DATA_AND_PRIVACY.md".
In the meanwhile, I've merged latest main, added the "New" badge in Settings and tweaked gpo and spellcheck a bit.

1. Yes, this is a mistake. I fixed it
2. Don't know why this is happening, but atleast it is not crashing anymore now.
3. I don't think your proposed idea would be easy to press. So I switched it to Ctrl+Shift+A
4. I added them

Thanks again for your review.

2. was crashing because of unauthorized access to Program Files link target path. I tested your fix. Looks like it's working correctly

[jaimecbernardo]

LGTM! Thank you for the fixes!
Ctrl+Shift+A also sounds like something that will conflict with other programs. I've set it to off by default. The "new" moniker on Settings should now help with discoverability and that way users can change the shortcut to what they prefer.

Copilot reviewed 185 out of 201 changed files in this pull request and generated no comments.

Files not reviewed (16)

• .github/actions/spell-check/expect.txt: Language not supported
• .github/actions/spell-check/patterns.txt: Language not supported
• .pipelines/ESRPSigning_core.json: Language not supported
• Directory.Packages.props: Language not supported
• PowerToys.sln: Language not supported
• installer/PowerToysSetup/Common.wxi: Language not supported
• installer/PowerToysSetup/FileActionsMenu.wxs: Language not supported
• installer/PowerToysSetup/PowerToysInstaller.wixproj: Language not supported
• installer/PowerToysSetup/Product.wxs: Language not supported
• installer/PowerToysSetup/generateAllFileComponents.ps1: Language not supported
• installer/PowerToysSetupCustomActions/CustomAction.cpp: Language not supported
• installer/PowerToysSetupCustomActions/PowerToysSetupCustomActions.vcxproj: Language not supported
• src/common/GPOWrapper/GPOWrapper.cpp: Language not supported
• src/common/GPOWrapper/GPOWrapper.h: Language not supported
• src/common/GPOWrapper/GPOWrapper.idl: Language not supported
• src/common/ManagedTelemetry/Telemetry/ManagedTelemetry.csproj: Language not supported

[yeelam-gordon]

Ctrl+Shift+A

This one conflict with Microsoft Word to make highlight word to capital.
Even Win+Shift+A is better in case

[yeelam-gordon]

I don't have objection beside the shortcut key as well.
There are many files has repeat pattern, but they looks good in general which I don't mean to update it.

[Aaron-Junker]

Ctrl+Shift+A

This one conflict with Microsoft Word to make highlight word to capital.
Even Win+Shift+A is better in case

But you cannot open File Actions Menu from Word anyway. But I'm also good with deactivating it

[cinnamon-msft]

After playing with this, I think providing the ability to add these items to the existing File Explorer context menu would feel more natural. Additionally, we should provide the ability to enable/disable the options as I don't think everyone will want everything. I'm going to block this for now while we investigate if we can extend the existing context menu.

[Aaron-Junker]

After playing with this, I think providing the ability to add these items to the existing File Explorer context menu would feel more natural. Additionally, we should provide the ability to enable/disable the options as I don't think everyone will want everything. I'm going to block this for now while we investigate if we can extend the existing context menu.

@cinnamon-msft the reason the whole thing was made was to have a menu which is way more customizable then the classic context menu. In the classic one you for instance cannot use checkbox menu items.

For enabling/disabling I find it a good idea, but this adds a new huge item to an already huge PR. Please reconsider your decision to block, cause this will just add another 1-2 months of setback.

[ukanuk]

Personally I'd have expected this to trigger in the same was as PowerRename -- Shift + Right-click an object(s) in File Explorer context menu, choose "PowerRename" in the context menu, then open a popup window where you select more specific details before executing.