[PTRun] - only show top window per process in WndWalker

[kice]

Summary of the Pull Request

Add a feature that allow to only show most top window (or "most recent window") for each process in Window Walker.

PR Checklist

• Closes: #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[jaimecbernardo]

Thank you for opening the PR.
Can you please sign the CLA?
I'm also checking the diff and many files seem to have lots of file ending changes, is this something you'd be able to fix to make it easier to review?
Thank you, in advance.

[kice]

@microsoft-github-policy-service agree

[kice]

Thank you for opening the PR. Can you please sign the CLA? I'm also checking the diff and many files seem to have lots of file ending changes, is this something you'd be able to fix to make it easier to review? Thank you, in advance.

Sorry for late reply, I think I fixed the line endings.

[jaimecbernardo]

Thank you for the contribution. I like how we avoid any performance impact by only running the code if the option is turned on.
However, there are some code quality issues I feel must be addressed. Can you please look into those? Thank you!

[jaimecbernardo]

Suggested change

	<value>Only show the top window of each processes.</value>
	<value>Only show the top window of each process.</value>

[jaimecbernardo]

This method seems to have many issues.
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getwindow#remarks

Also feel uneasy seeing a while(true) in here.
Can you use the EnumChildWindows or EnumWindows as suggested instead?
https://learn.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-enumwindows#remarks

[kice]

The document call for use GetNextWindow, which is implemented as a call to the GetWindow function.

I think EnumChildWindows or EnumWindows do not guarantee the function enumerate in the correct z-order.

Maybe we could add some checks to prevent the infinite loop; but still this could return incomplete results, and we don't need to handle that case.

In the case of incomplete results, I assume the application will use the first window in the result list, and usually be the top window of that process. The users should be able to retry as well, and then likely get the complete result next time.

Ref:
https://stackoverflow.com/questions/295996/is-the-order-in-which-handles-are-returned-by-enumwindows-meaningful

[jaimecbernardo]

I think EnumChildWindows or EnumWindows do not guarantee the function enumerate in the correct z-order.

It might do it, according to the stack overflow answer you've posted:

We'd prefer going with a solution that the documentation doesn't point out as unreliable 😉 . Does this make sense to you?

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Files not reviewed (2)

• src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Properties/Resources.Designer.cs: Language not supported
• src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Properties/Resources.resx: Language not supported

Comments suppressed due to low confidence (1)

src/modules/launcher/Plugins/Microsoft.Plugin.WindowWalker/Components/ResultHelper.cs:29

• Ensure that the new behavior introduced in ResultHelper.cs for grouping and selecting the top window per process is covered by tests.

if (WindowWalkerSettings.Instance.ResultsFromTopWindowPerProcess)