Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed double suggestions when using vscode workspaces plugin #31359

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Removed double suggestions when using vscode workspaces plugin #31359

wants to merge 1 commit into from
+45 −38

Conversation

coldfeudal
Copy link

Summary of the Pull Request

When using VSCode Workspaces plugins, I always stumble upon double the amount of results of tips when searching. Made a fix to prevent this from happening
image

@coldfeudal
Copy link
Author

@microsoft-github-policy-service agree

@Jay-o-Way Jay-o-Way requested a review from htcfreek February 8, 2024 16:01
@Jay-o-Way Jay-o-Way added the Run-Plugin Things that relate with PowerToys Run's plugin interface label Feb 8, 2024
@htcfreek
Copy link
Collaborator

htcfreek commented Feb 8, 2024

@coldfeudal
Can you please

  1. creat an issue where we can track the issue and reference it in the PR description. (If one already exists please reference that.)
  2. describe what the cause of the duplicated paths is. I am wondering why a workspace can exist multiple times? 🤔
  3. Add screenshot how it looked before and after. I saw that you changed something on the title and description. (As I don't have any workspaces it is hard to review without screenshots.)
  4. Describe what changes you implement for title and description and why.

@jaimecbernardo jaimecbernardo added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@htcfreek htcfreek

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something Run-Plugin Things that relate with PowerToys Run's plugin interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coldfeudal @htcfreek @jaimecbernardo @Jay-o-Way