-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Actions Menu dev docs #31668
base: main
Are you sure you want to change the base?
File Actions Menu dev docs #31668
Conversation
| `FileActionsMenuPowerRenameAction` | When PowerRename is launched via File Actions Menu | | | ||
| `FileActionsMenuImageResizerAction` | When Image Resizer is launched via File Actions Menu | | | ||
| `FileActionsMenuFileLocksmithAction` | When File Locksmith is launched via File Actions Menu | | | ||
| `FileActionsMenuCopyContentAsCEscapedStringActionInvokedEvent` | When the "Copy file content → As C escaped string" action is invoked | | |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
|
||
## Sending telemetry events | ||
|
||
Telemetry events that implement `FileActionsMenuProgressConflictEvent` are sent with the `TelemetryHelper.LogEvent` method. The `selectedItems` parameter is an array of the selected items. For more information, see the [Helpers docs](Helpers.md#void-logeventtt-e-string-selecteditems-where-t--eventbase-ifileactionsmenuiteminvokedevent). |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
|
||
## Sending telemetry events | ||
|
||
Telemetry events that implement `FileActionsMenuProgressConflictEvent` are sent with the `TelemetryHelper.LogEvent` method. The `selectedItems` parameter is an array of the selected items. For more information, see the [Helpers docs](Helpers.md#void-logeventtt-e-string-selecteditems-where-t--eventbase-ifileactionsmenuiteminvokedevent). |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
|
||
## Sending telemetry events | ||
|
||
Telemetry events that implement `FileActionsMenuProgressConflictEvent` are sent with the `TelemetryHelper.LogEvent` method. The `selectedItems` parameter is an array of the selected items. For more information, see the [Helpers docs](Helpers.md#void-logeventtt-e-string-selecteditems-where-t--eventbase-ifileactionsmenuiteminvokedevent). |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
|
||
## Sending telemetry events | ||
|
||
Telemetry events that implement `FileActionsMenuProgressConflictEvent` are sent with the `TelemetryHelper.LogEvent` method. The `selectedItems` parameter is an array of the selected items. For more information, see the [Helpers docs](Helpers.md#void-logeventtt-e-string-selecteditems-where-t--eventbase-ifileactionsmenuiteminvokedevent). |
Check failure
Code scanning / check-spelling
Unrecognized Spelling Error documentation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check-spelling found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details. Unrecognized words (18)
Previously acknowledged words that are now absentCOMMANDTITLE FILELOCKSMITHLIB OOBEPT 🫥To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands... in a clone of the git@github.com:microsoft/PowerToys.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.22/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/8726639449/attempts/1' Available 📚 dictionaries could cover words (expected and unrecognized) not in the 📘 dictionaryThis includes both expected items (1873) from .github/actions/spell-check/expect.txt and unrecognized words (18)
Consider adding them (in with:
extra_dictionaries:
cspell:r/src/r.txt
cspell:cpp/src/people.txt
cspell:cpp/src/ecosystem.txt To stop checking additional dictionaries, add (in check_extra_dictionaries: '' If the flagged items are 🤯 false positivesIf items relate to a ...
|
Hey @Aaron-Junker l, how's this going? |
Waiting for the main PR to be merged, so I can add links to the files. Otherwise it should be finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 5 out of 15 changed files in this pull request and generated 7 comments.
Files not reviewed (10)
- doc/devdocs/modules/FileActionsMenu/readme.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins/FileProperties.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/PublicTypes.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Enums.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins/ImageClipboardActions.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins/PowerToys.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins/MoveCopyActions.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Telemetry.md: Evaluated as low risk
- doc/devdocs/modules/FileActionsMenu/Plugins/ExecutableActions.md: Evaluated as low risk
The category number of the action. Different categories are seperated by a seperator in the top-level menu. Best practice is that third-party plugins use numbers between `100` and `998`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'seperator' is misspelled. It should be 'separator'.
The category number of the action. Different categories are seperated by a seperator in the top-level menu. Best practice is that third-party plugins use numbers between `100` and `998`. | |
The category number of the action. Different categories are separated by a separator in the top-level menu. Best practice is that third-party plugins use numbers between `100` and `998`. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Determines whetever the action is visible in the menu or not. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'whetever' is misspelled. It should be 'whether'.
Determines whetever the action is visible in the menu or not. | |
Determines whether the action is visible in the menu or not. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Abstract class that defines a checkable action. You always have to have atleast two checkable actions. If you check one item of a group, all the other items will be unchecked. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'atleast' is misspelled. It should be 'at least'.
Abstract class that defines a checkable action. You always have to have atleast two checkable actions. If you check one item of a group, all the other items will be unchecked. | |
Abstract class that defines a checkable action. You always have to have at least two checkable actions. If you check one item of a group, all the other items will be unchecked. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Get whetever the current element is checked or not. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'whetever' is misspelled. It should be 'whether'.
Get whetever the current element is checked or not. | |
Get whether the current element is checked or not. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Whetever the current item is checked by default. There must be exactly one item per group that has this property set to `true`. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'whetever' is misspelled. It should be 'whether'.
Whetever the current item is checked by default. There must be exactly one item per group that has this property set to `true`. | |
Whether the current item is checked by default. There must be exactly one item per group that has this property set to `true`. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
|
||
### `CheckedMenuItemsDictionary CheckedMenuItemsDictionary` | ||
|
||
This dictionairy contains all the checkable menu items per group (defined by the group UUID). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'dictionairy' is misspelled. It should be 'dictionary'.
This dictionairy contains all the checkable menu items per group (defined by the group UUID). | |
This dictionary contains all the checkable menu items per group (defined by the group UUID). |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
The hashes are saved to files with the same filenames as the oriiginal files with the hash type as file extension. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'oriiginal' is misspelled. It should be 'original'.
The hashes are saved to files with the same filenames as the oriiginal files with the hash type as file extension. | |
The hashes are saved to files with the same filenames as the original files with the hash type as file extension. |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed