Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make preview windows focusable, so you can Ctrl+C/Ctrl+V out of it. #32478

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Aaron-Junker
Copy link
Collaborator

Summary of the Pull Request

Allows copying with shortcuts out of preview windows (And also stuff like selecting everything with Ctrl+A). And allows using monaco shortcuts (like Ctrl+F) in the dev file previewer

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@Aaron-Junker Aaron-Junker added the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 16, 2024

This comment has been minimized.

@Aaron-Junker Aaron-Junker removed the Needs-Review This Pull Request awaits the review of a maintainer. label Apr 16, 2024
@Aaron-Junker Aaron-Junker marked this pull request as draft April 16, 2024 19:38
@Aaron-Junker Aaron-Junker added the Needs-Review This Pull Request awaits the review of a maintainer. label Sep 28, 2024
@Aaron-Junker Aaron-Junker marked this pull request as ready for review September 28, 2024 20:38

This comment has been minimized.

@microsoft microsoft deleted a comment from github-actions bot Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • .github/actions/spell-check/expect.txt: Language not supported
Comments suppressed due to low confidence (1)

src/modules/previewpane/common/controls/FormHandlerControl.cs:133

  • Ensure that the removal of the WS_CHILD style and related code is covered by tests to prevent any unintended side effects.
int windowStyle = NativeMethods.GetWindowLong(Handle, gwlStyle);
@@ -545,6 +545,7 @@
GUITHREADINFO
GValue
gwl
GWL

Check warning

Code scanning / check-spelling

Ignored Expect Variant Warning

GWL is ignored by check spelling because another more general variant is also in expect. (ignored-expect-variant)
Copy link

@check-spelling-bot Report

🔴 Please review

See the 📂 files view, the 📜action log, or 📝 job summary for details.

Unrecognized words (1)

GWL

These words are not needed and should be removed ahk AMPROPERTY AMPROPSETID Breadcrumb CDEF comdef ddf devenum DEVMON DEVSOURCE DGR DIIRFLAG dshow DVH DVHD DVSD DVSL EData ERole fdw FILEINFOSIG Filtergraph Filterx gwl HCERTSTORE IKs iljxck IYUV KSPROPERTY lcb ldx lld LONGLONG LTRB majortype makecab MEDIASUBTYPE mediatype mfplat mic mjpg Msimg msiquery ORAW outpin overlaywindow PAUDIO PINDIR Pnp ppmt previouscamera PROPBAG propvarutil reencode reencoded REFGUID REGFILTER REGFILTERPINS REGPINTYPES regsvr shmem sizeread stl strsafe strutil subquery SYNCMFT TMPVAR vcdl vdi vid VIDCAP VIDEOINFOHEADER vih webcam wistd WVC

To accept these unrecognized words as correct and remove the previously acknowledged and now absent words, you could run the following commands

... in a clone of the git@github.com:microsoft/PowerToys.git repository
on the dev/aaron-junker/focus-filePreview branch (ℹ️ how do I use this?):

curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/v0.0.24/apply.pl' |
perl - 'https://github.com/microsoft/PowerToys/actions/runs/13433824444/attempts/1'
Errors (1)

See the 📂 files view, the 📜action log, or 📝 job summary for details.

❌ Errors Count
❌ ignored-expect-variant 1

See ❌ Event descriptions for more information.

If the flagged items are 🤯 false positives

If items relate to a ...

  • binary file (or some other file you wouldn't want to check at all).

    Please add a file path to the excludes.txt file matching the containing file.

    File paths are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your files.

    ^ refers to the file's path from the root of the repository, so ^README\.md$ would exclude README.md (on whichever branch you're using).

  • well-formed pattern.

    If you can write a pattern that would match it,
    try adding it to the patterns.txt file.

    Patterns are Perl 5 Regular Expressions - you can test yours before committing to verify it will match your lines.

    Note that patterns can't match multiline strings.

@stefansjfw
Copy link
Collaborator

Hi Aaron, sorry for keeping this under review this long. The problem I see with this approach is that preview pane cannot be resized anymore. I assume there are other downsides of making it a non-child window.. So, let's try ti find some other way to make this possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants