Change log extension #33813
Open
Change log extension #33813
+33
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From .txt to .log
|
@microsoft-github-policy-service agree |
|
Is this backwards compatible or a breaking change? |
|
Unless there are automated tools to read log bundles that I don't know
about, this should not break anything.
…On Sun, Jul 14, 2024, 08:26 Jay ***@***.***> wrote:
Is this backwards compatible or a breaking change?
—
Reply to this email directly, view it on GitHub
<#33813 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKJ7E3LUUVV6AZ4XHQ3GGTZMJ4A5AVCNFSM6AAAAABKZZZBHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRXGM2DQOBYHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Is there any interest in this PR? |
crutkas
added
the
Needs-Review
|
Sorry, right now the team was heads down on workspaces and getting stuff prepped for winappsdk upgrade. Added need review tag for this. /azp run as it looks like it has test failures, lets see if this was random since i don't think this should have caused that failure |
|
Merged in latest main. Note to self: when testing, verify that the tools/ executables take this into account, some of them seem to require using log and we have to verify when testing that they're still picking up the files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From .txt to .log
Summary of the Pull Request
Changes the log file extension to
.logfor enhanced tool usage.PR Checklist
Detailed Description of the Pull Request / Additional comments
Changed all log file extensions from
.txtto.log. This honors system and user defined file associations like CMTrace. It also automatically enables syntax highlighting in software like VSCode.Validation Steps Performed
Manually verified log files and bundled support zip.