WinGet manifest Keyboard Shortcuts extension

[Aaron-Junker]

Summary of the Pull Request

Work for Shortcut Guide v2

PR Checklist

• Closes: #xxx
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[Aaron-Junker]

This is ready for review now

[Copilot]

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

Files not reviewed (1)

• .github/actions/spell-check/expect.txt: Language not supported

Comments suppressed due to low confidence (2)

doc/specs/Winget Manifest Keyboard Shortcuts schema.md:23

• The example filename is missing a closing quotation mark. It should be corrected to test.bar.en-US.KBSC.yaml.

For example the package "test.bar" saves its manifest with `en-US` strings in `test.bar.en-US.KBSC.yaml"

doc/specs/Winget Manifest Keyboard Shortcuts schema.md:276

• The key 'Filter' should be 'WindowFilter' to be consistent with the rest of the document.

- Filter: "*"

[Copilot]

The phrase 'An string array' should be corrected to 'A string array'.

Suggested change

	An string array of all the keys that need to be pressed. If a number is supplied, it should be read as a [KeyCode](https://learn.microsoft.com/windows/win32/inputdev/virtual-key-codes) and displayed accordingly (based on the Keyboard Layout of the user).
	A string array of all the keys that need to be pressed. If a number is supplied, it should be read as a [KeyCode](https://learn.microsoft.com/windows/win32/inputdev/virtual-key-codes) and displayed accordingly (based on the Keyboard Layout of the user).

[yeelam-gordon]

Thanks for your effort and passion in writing this up!

The spec doesn’t explicitly mention its purpose/goal, so let me clarify the intended goal. I assume this is designed to simplify configuring and restoring shortcut keys for PowerToys modules via WinGet configuration—please let me know if that’s not the case.

From what I see, the location and example provided seem to extend beyond just PowerToys. If your goal is to support any Windows app, not just PowerToys, I recommend explicitly specifying this in the Goal section to avoid ambiguity.

Additionally, based on the spec, I suggest considering the following aspects:

Expected behavior for multiple shortcut manifests – Should they merge, override, or warn about conflicts?
How the manifest is updated – When users modify their preferences, what’s the expected process for exporting and applying changes?
Handling duplicate shortcut definitions – How should duplicates within the same manifest or across multiple manifests be managed?
Looking forward to your thoughts!

[Aaron-Junker]

Thanks for your effort and passion in writing this up!

The spec doesn’t explicitly mention its purpose/goal, so let me clarify the intended goal. I assume this is designed to simplify configuring and restoring shortcut keys for PowerToys modules via WinGet configuration—please let me know if that’s not the case.

From what I see, the location and example provided seem to extend beyond just PowerToys. If your goal is to support any Windows app, not just PowerToys, I recommend explicitly specifying this in the Goal section to avoid ambiguity.

Additionally, based on the spec, I suggest considering the following aspects:

Expected behavior for multiple shortcut manifests – Should they merge, override, or warn about conflicts? How the manifest is updated – When users modify their preferences, what’s the expected process for exporting and applying changes? Handling duplicate shortcut definitions – How should duplicates within the same manifest or across multiple manifests be managed? Looking forward to your thoughts!

Hi @yeelam-gordon. Thank you for your feedback. This spec stands in relation to Shortcut Guide V2 which was discussed internally.

I changed the PR back to a draft so I can implement some clarifications and adress your questions.