Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PTRun][OneNote] Improve the OneNote plugin #36813

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Prev Previous commit
Next Next commit
Small code clean up
  • Loading branch information
Odotocodot committed Jan 18, 2025
commit 8557a4020f9533e35dbe08216251cfd085e73ea3
Original file line number Diff line number Diff line change
@@ -147,33 +147,35 @@ private List<Result> Explorer(string search, IOneNoteItem? parent, IEnumerable<I

private void AddCreateNewOneNoteItemResults(string newItemName, IOneNoteItem? parent, List<Result> results)
{
if (!results.Any(result => string.Equals(newItemName.Trim(), result.Title, StringComparison.OrdinalIgnoreCase)))
if (results.Any(result => string.Equals(newItemName.Trim(), result.Title, StringComparison.OrdinalIgnoreCase)))
{
if (parent?.IsInRecycleBin() == true)
{
return;
}
return;
}

switch (parent)
{
case null:
results.Add(_resultCreator.CreateNewNotebookResult(newItemName));
break;
case OneNoteNotebook:
case OneNoteSectionGroup:
results.Add(_resultCreator.CreateNewSectionResult(newItemName, parent));
results.Add(_resultCreator.CreateNewSectionGroupResult(newItemName, parent));
break;
case OneNoteSection section:
if (!section.Locked)
{
results.Add(_resultCreator.CreateNewPageResult(newItemName, section));
}

break;
default:
break;
}
if (parent?.IsInRecycleBin() == true)
{
return;
}

switch (parent)
{
case null:
results.Add(_resultCreator.CreateNewNotebookResult(newItemName));
break;
case OneNoteNotebook:
case OneNoteSectionGroup:
results.Add(_resultCreator.CreateNewSectionResult(newItemName, parent));
results.Add(_resultCreator.CreateNewSectionGroupResult(newItemName, parent));
break;
case OneNoteSection section:
if (!section.Locked)
{
results.Add(_resultCreator.CreateNewPageResult(newItemName, section));
}

break;
default:
break;
}
}
}
Original file line number Diff line number Diff line change
@@ -60,9 +60,10 @@ private List<Result> DefaultSearch(string query)
}

var results = OneNoteApplication.FindPages(query)
.Select(pg => _resultCreator.CreatePageResult(pg, query));
.Select(pg => _resultCreator.CreatePageResult(pg, query))
.ToList();

return results.Any() ? results.ToList() : _resultCreator.NoMatchesFound(showSingleResults);
return results.Count != 0 ? results : _resultCreator.NoMatchesFound(showSingleResults);
}

private List<Result> TitleSearch(string query, IOneNoteItem? parent, IEnumerable<IOneNoteItem> currentCollection)