Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New+ Support for variables in template filenames (35287) #37074

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
bd175a2
Add variable support - initial version without UI
cgaarden Dec 22, 2024
7e36a23
Add variable in template filename support in New+
cgaarden Dec 22, 2024
0f5a8ed
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Dec 26, 2024
bb3c47d
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
cgaarden Jan 23, 2025
b7bf769
Several little fixes
cgaarden Jan 23, 2025
e3824f4
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 24, 2025
bd13af1
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
cgaarden Jan 25, 2025
cca4878
New+feature-35287-support-for-variables-in-templates
cgaarden Jan 25, 2025
1fc8d65
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 25, 2025
51ca5b8
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 25, 2025
ba4f07e
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 25, 2025
a8b6a1c
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 25, 2025
81240c3
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Jan 26, 2025
0b41e5b
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
cgaarden Jan 29, 2025
d40aae2
Merge branch 'microsoft:main' into New+feature-35287-support-for-vari…
cgaarden Jan 29, 2025
1b2d01d
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
cgaarden Feb 15, 2025
b9be940
Merge branch 'New+feature-35287-support-for-variables-in-templates' o…
cgaarden Feb 15, 2025
6b1f684
Merge branch 'main' into pr37074
jaimecbernardo Feb 25, 2025
643bec6
Fix XAML style
jaimecbernardo Feb 25, 2025
4fee67a
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
cgaarden Feb 26, 2025
e869120
Addressed code review feedback
cgaarden Feb 26, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge remote-tracking branch 'upstream/main' into New+feature-35287-s…
…upport-for-variables-in-templates
  • Loading branch information
cgaarden committed Feb 15, 2025
commit 1b2d01ddbbc9c400b225c45a8c66681998ef031f
4 changes: 4 additions & 0 deletions src/common/GPOWrapper/GPOWrapper.cpp
Original file line number Diff line number Diff line change
@@ -236,4 +236,8 @@ namespace winrt::PowerToys::GPOWrapper::implementation
{
return static_cast<GpoRuleConfigured>(powertoys_gpo::getConfiguredNewPlusReplaceVariablesValue());
}
GpoRuleConfigured GPOWrapper::GetConfiguredRunAtStartupValue()
{
return static_cast<GpoRuleConfigured>(powertoys_gpo::getConfiguredRunAtStartupValue());
}
}
1 change: 1 addition & 0 deletions src/common/GPOWrapper/GPOWrapper.h
Original file line number Diff line number Diff line change
@@ -63,6 +63,7 @@ namespace winrt::PowerToys::GPOWrapper::implementation
static winrt::hstring GPOWrapper::GetConfiguredMwbPolicyDefinedIpMappingRules();
static GpoRuleConfigured GetConfiguredNewPlusHideTemplateFilenameExtensionValue();
static GpoRuleConfigured GetAllowDataDiagnosticsValue();
static GpoRuleConfigured GetConfiguredRunAtStartupValue();
static GpoRuleConfigured GetConfiguredNewPlusReplaceVariablesValue();
};
}
1 change: 1 addition & 0 deletions src/common/GPOWrapper/GPOWrapper.idl
Original file line number Diff line number Diff line change
@@ -67,6 +67,7 @@ namespace PowerToys
static String GetConfiguredMwbPolicyDefinedIpMappingRules();
static GpoRuleConfigured GetConfiguredNewPlusHideTemplateFilenameExtensionValue();
static GpoRuleConfigured GetAllowDataDiagnosticsValue();
static GpoRuleConfigured GetConfiguredRunAtStartupValue();
static GpoRuleConfigured GetConfiguredNewPlusReplaceVariablesValue();
}
}
1 change: 0 additions & 1 deletion src/gpo/assets/en-US/PowerToys.adml
Original file line number Diff line number Diff line change
@@ -297,7 +297,6 @@ If you don't configure this policy, the user will be able to control the setting
<string id="MwbPolicyDefinedIpMappingRules">Predefined IP Address mapping rules</string>
<string id="NewPlusHideTemplateFilenameExtension">Hide template filename extension</string>
<string id="AllowDiagnosticData">Allow sending diagnostic data</string>
<string id="NewPlusReplaceVariablesInTemplateFilenames">Replace variables in template filenames</string>
</stringTable>

<presentationTable>
You are viewing a condensed version of this merge commit. You can view the full changes here.