Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Use Download Task for X64 and Bypass ARM Testing for Forked Repositories #37617

Merged
merged 6 commits into from
Feb 27, 2025

Conversation

lei9444
Copy link
Contributor

@lei9444 lei9444 commented Feb 25, 2025

Summary of the Pull Request

Root cause:

Forked repositories cannot obtain an access token for authentication due to the SFI requirement.
ARM experiences an out-of-memory issue when use download task.

PR change:

Skipped the test stage for ARM testing on forked repositories.
Used the download task for X64 to ensure X64 tests always run successfully.

image

PR Checklist

  • Closes: #xxx
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@lei9444
Copy link
Contributor Author

lei9444 commented Feb 26, 2025

/azp run

Copy link

Azure Pipelines failed to run 1 pipeline(s).

This comment has been minimized.

@lei9444 lei9444 marked this pull request as ready for review February 26, 2025 07:47
@lei9444 lei9444 requested a review from a team as a code owner February 26, 2025 07:47
@lei9444 lei9444 changed the title [CI] Use the download task for X64 to ensure the X64 download artifact functions correctly [CI] Use Download Task for X64 and Bypass ARM Testing for Forked Repositories Feb 26, 2025
Copy link
Contributor

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.pipelines/v2/templates/pipeline-ci-build.yml:75

  • The conditional uses 'platform' while other templates (e.g., job-test-project.yml) reference 'parameters.platform'. Please verify that the correct variable is used for consistency in architecture checks.
-    - ${{ if and(eq(parameters.runTests, true), not(and(eq(platform, 'arm64'), eq(variables['System.PullRequest.IsFork'], true)))) }}:

.pipelines/v2/templates/job-test-project.yml:64

  • Confirm that 'parameters.platform' accurately represents the target platform in this conditional and aligns with variables used elsewhere in the CI pipelines to avoid misconfiguration.
+  - ${{ if ne(parameters.platform, 'arm64') }}:
@Youssef1313 Youssef1313 mentioned this pull request Feb 26, 2025
@lei9444 lei9444 merged commit bf26857 into microsoft:main Feb 27, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants