-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Use Download Task for X64 and Bypass ARM Testing for Forked Repositories #37617
Conversation
/azp run |
Azure Pipelines failed to run 1 pipeline(s). |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
.pipelines/v2/templates/pipeline-ci-build.yml:75
- The conditional uses 'platform' while other templates (e.g., job-test-project.yml) reference 'parameters.platform'. Please verify that the correct variable is used for consistency in architecture checks.
- - ${{ if and(eq(parameters.runTests, true), not(and(eq(platform, 'arm64'), eq(variables['System.PullRequest.IsFork'], true)))) }}:
.pipelines/v2/templates/job-test-project.yml:64
- Confirm that 'parameters.platform' accurately represents the target platform in this conditional and aligns with variables used elsewhere in the CI pipelines to avoid misconfiguration.
+ - ${{ if ne(parameters.platform, 'arm64') }}:
Summary of the Pull Request
Root cause:
Forked repositories cannot obtain an access token for authentication due to the SFI requirement.
ARM experiences an out-of-memory issue when use download task.
PR change:
Skipped the test stage for ARM testing on forked repositories.
Used the download task for X64 to ensure X64 tests always run successfully.
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed