Don't open exclusive handles when reading shortcuts

[OneBlue]

This updates the ShellLinkHelper logic to pass the STGM_SHARE_DENY_NONE when reading desktop shortcuts to make sure that powertoys doesn't interfere with other programs.

See: microsoft/WSL#11276 (comment)

PR Checklist

• Closes: PowerLauncher.exe causes other running MSI installers to fail to set up the shortcut #34391
• Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
• Tests: Added/updated and all pass
• Localization: All end user facing strings can be localized
• Dev docs: Added/updated
• New binaries: Added on the required places
  • JSON for signing for new binaries
  • WXS for installer for new binaries and localization folder
  • YML for CI pipeline for new test projects
  • YML for signed pipeline
• Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

[htcfreek]

cc @zadjii-msft

[crutkas]

We should be sure this fix is in cmdpal

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

src/modules/launcher/Wox.Infrastructure/ShellLinkHelper.cs:141

• [nitpick] Consider centralizing the STGM_* constants into a shared utility or header if they are used elsewhere, which would improve maintainability and clarity.

const int STGM_SHARE_DENY_NONE = 0x00000040;

src/modules/launcher/Wox.Infrastructure/ShellLinkHelper.cs:145

• Ensure that unit tests are updated or added to cover scenarios where the shortcut file is accessed concurrently so that the change in sharing mode does not introduce regressions.

((IPersistFile)link).Load(path, STGM_READ | STGM_SHARE_DENY_NONE);

[yeelam-gordon]

Yu will help on try out the fix

[moooyo]

I'm not sure, but seems I can still repo this issues with your fix.

Repo steps:

1. follow up this repo to get three msi for testing. https://github.com/avjts/powerlauncher-bug
2. Install the specific powertoys version (with this fix)
3. Install the first msi.
4. Disable and re-enable PowerToys Run
5. Install the second and third msi.

[OneBlue]

Thank you for trying this out @moooyo. I couldn't build an installer locally so I was planning to use the CI to get it and validate the change. If that doesn't solve it, it might mean that the exclusive handle is coming from another place. Does powertoys open desktop shortcuts from somewhere else ?

[htcfreek]

Does powertoys open desktop shortcuts from somewhere else ?

Did you check the program plugin? It scans the desktop shortcuts.

[jaimecbernardo]

@OneBlue , please check #37654 . That fix seems to be working for us. Can you please verify?

[jaimecbernardo]

Closing in favor of #37654