Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update WinGet configuration file location & extension #37673

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

mdanish-kh
Copy link
Contributor

@mdanish-kh mdanish-kh commented Feb 27, 2025

Summary of the Pull Request

The new convention for WinGet configuration files if to place them in a .config directory with file extension .winget. See https://learn.microsoft.com/en-us/windows/package-manager/configuration/create#file-naming-convention

PR Checklist

  • Closes: #
  • Communication: I've discussed this with core contributors already. If work hasn't been agreed, this work might be rejected
  • Tests: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Dev docs: Added/updated
  • New binaries: Added on the required places
  • Documentation updated: If checked, please file a pull request on our docs repo and link it here: #xxx

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

@mdanish-kh mdanish-kh changed the title Update configuration file location & extension Update WinGet configuration file location & extension Feb 27, 2025
@denelon
Copy link
Contributor

denelon commented Feb 27, 2025

Related to:

@crutkas
Copy link
Member

crutkas commented Feb 28, 2025

nice!

@crutkas
Copy link
Member

crutkas commented Feb 28, 2025

can we move the .configurations into the .config folder?

@mdanish-kh
Copy link
Contributor Author

@crutkas Are you suggesting a structure as .config/. configurations/<.winget files>? I'm not sure if that would be in line with the recommendation 🤔. @denelon Any thoughts?

@mdanish-kh
Copy link
Contributor Author

My only concern would be if others start to adopt the powertoys way since it has been mentioned as a "reference repository" in quite a few places

@denelon
Copy link
Contributor

denelon commented Feb 28, 2025

I agree @mdanish-kh. The guidance is written as:

".config/configuration.winget" <- Default Configuration
".config/.winget" <- Other Configurations

It could be confusing to have the following since we no longer reference a ".configuration" directory.

"./config/.configurations/configuration.winget"

@crutkas
Copy link
Member

crutkas commented Feb 28, 2025

I misread the paths, sorry, you did it correct

@denelon
Copy link
Contributor

denelon commented Feb 28, 2025

@mdanish-kh I'm not sure it should close the issue. I think there might still need to be changes in the configuration files to handle the securityContext: elevated. The configurations work when run elevated, but in user scope, I think enabling developer mode fails (but checking if it's in the right state works) due to lacking administrator privileges. I don't remember if installing Visual Studio requires elevation or not.

@mdanish-kh
Copy link
Contributor Author

@denelon - I don't remember adding that bit in the description (looks like I'm right that I didn't 😆😆😄). Anyways, that makes sense & removed the closes issue ref

Copy link

@yeelam-gordon yeelam-gordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to make it align with the practice of format

@crutkas
Copy link
Member

crutkas commented Mar 4, 2025

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@crutkas crutkas merged commit cca3f44 into microsoft:main Mar 4, 2025
10 checks passed
@mdanish-kh mdanish-kh deleted the config-convention branch March 4, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants