Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RegistryPreview] Enhanced preview for value data #37689

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

htcfreek
Copy link
Collaborator

@htcfreek htcfreek commented Feb 28, 2025

Summary of the Pull Request

Add a button to the data grid that shows a windows for complex value preview.

Button
image

Preview: REG_SZ
image

Preview: REG_MULTI_SZ
image

Preview: REG_EXPAND_SZ
image

Preview: REG_DWORD and REG_QWORD
image

Preview: REG_BINARY

image
image

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek changed the title 🚧 [RegistryPreview] Enhanced preview windows for value data [RegistryPreview] Enhanced preview windows for value data Mar 1, 2025
@htcfreek htcfreek self-assigned this Mar 1, 2025
@htcfreek htcfreek marked this pull request as ready for review March 1, 2025 15:27
@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Mar 1, 2025
@htcfreek htcfreek requested a review from niels9001 March 1, 2025 15:28
@htcfreek htcfreek changed the title [RegistryPreview] Enhanced preview windows for value data [RegistryPreview] Enhanced preview for value data Mar 1, 2025
@htcfreek htcfreek marked this pull request as draft March 1, 2025 18:40
@htcfreek

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@htcfreek htcfreek marked this pull request as ready for review March 2, 2025 17:07
@htcfreek htcfreek added the Product-Registry Preview Refers to the Registry Preview PowerToy label Mar 2, 2025
@htcfreek htcfreek marked this pull request as draft March 2, 2025 19:18
@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 2, 2025

@davidegiacometti, @niels9001 , @jaimecbernardo
There is a bug in the HexBox control that after selecting text in the HexBox control, the selected text on all other text boxes on the same content dialog is transparent when selecting it. Can you please take a look if you find a workaround/solution for this or if you have an idea how we can work around this bug. (Removing the HexBox after switching to "Text" view solves the bug.)

@htcfreek
Copy link
Collaborator Author

htcfreek commented Mar 3, 2025

@davidegiacometti, @niels9001 , @jaimecbernardo There is a bug in the HexBox control that after selecting text in the HexBox control, the selected text on all other text boxes on the same content dialog is transparent when selecting it. Can you please take a look if you find a workaround/solution for this or if you have an idea how we can work around this bug. (Removing the HexBox after switching to "Text" view solves the bug.)

I found the reason and opened a PR to fix it and implement new features: hotkidfamily/HexBox.WinUI/pull/12 . (If the approval and merge needs to much time: Maybe we can implement the fixed version directly into our code or can provide our own nuget package.)

And by the way, the control has a context menu that is currently not localized.

@htcfreek htcfreek added External Dependency This bug or feature isn't resolved, but it's following an external work item. Status-Blocked We can't make progress due to a dependency or issue and removed Needs-Review This Pull Request awaits the review of a maintainer. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Dependency This bug or feature isn't resolved, but it's following an external work item. Product-Registry Preview Refers to the Registry Preview PowerToy Status-Blocked We can't make progress due to a dependency or issue
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant