Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAI api refactor #391

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+77 −0
Draft

OAI api refactor #391

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fb9352
OAI api
you-n-g Sep 29, 2024
8408dbd
more comments
you-n-g Sep 29, 2024
b8c5d73
llm utils
you-n-g Sep 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
llm utils
  • Loading branch information
@you-n-g
you-n-g committed Sep 29, 2024
commit b8c5d73985e094399130741acff20d21c4b27159
4 changes: 2 additions & 2 deletions rdagent/oai/llm_utils.py
View file
Original file line number Diff line number Diff line change
@@ -241,8 +241,8 @@ class APIBackend:
(xiao) thinks integerate all kinds of API in a single class is not a good design.
So we should split them into different classes in `oai/backends/` in the future.
"""
# FIXME: (xiao) I think we should skip using self.xxxx
# We can use self.cfg directly. If it is hard to 兼容 different settings of backends. We can split it into multiple BaseSettings.
# FIXME: (xiao) We should avoid using self.xxxx.
# Instead, we can use self.cfg directly. If it's difficult to support different backend settings, we can split them into multiple BaseSettings.
def __init__( # noqa: C901, PLR0912, PLR0915
self,
*,
Loading
Oops, something went wrong.