#61082 breaks @uswds/uswds deep module resolution in DT

[sandersn]

🔎 Search Terms

deep module resolution 61082

🕗 Version & Regression Information

• This changed in commit or PR Fix accidental ESM-mode directory module lookup in package non-root #61082

💻 Code

#61082 breaks @uswds/uswds on Definitely Typed:

import("@uswds/uswds").then((imports) => {
    Object.keys(components).forEach((key) => {
        const component = imports[key as ComponentKey];
        component.on(); // $ExpectType void
        component.on(element); // $ExpectType void
        component.off(); // $ExpectType void
        component.off(element); // $ExpectType void
    });
});
import("@uswds/uswds/src/js/components").then((imports) => {
    Object.keys(components).forEach((key) => {
        const component = imports[key as ComponentKey];
        component.on(); // $ExpectType void
        component.on(element); // $ExpectType void
        component.off(); // $ExpectType void
        component.off(element); // $ExpectType void
    });
});

package.json doesn't have anything fancy that I can see:

{
    "private": true,
    "name": "@types/uswds__uswds",
    "version": "3.11.9999",
    "projects": [
        "https://github.com/uswds/uswds"
    ],
    "devDependencies": {
        "@types/uswds__uswds": "workspace:."
    },
    "owners": [
        {
            "name": "Morgan Spencer",
            "githubUsername": "lunchbreakdev"
        },
        {
            "name": "Andrew Duthie",
            "githubUsername": "aduth"
        }
    ]
}

🙁 Actual behavior

The first block here resolves "@uswds/uswds"; the second doesn't resolve "@uswds/uswds/src/js/components".

🙂 Expected behavior

Previously, the second block resolved.

Additional information about the issue

This is probably a good break, but I don't understand why.

[sandersn]

"@uswds/uswds/src/js/components" should be "@uswds/uswds/src/js/components/index.js" for compatibility with ES module resolution. DefinitelyTyped/DefinitelyTyped#72083 fixes this on DT