Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create export declaration in Import_may_be_converted_to_a_default_import codefix when the original node has export modifier #61173

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create export declaration in Import_may_be_converted_to_a_default_import codefix when the original node has export modifier #61173

wants to merge 3 commits into from

Conversation

Andarist
Copy link
Contributor

fixes #61167

@Andarist
Create export declaration in `Import_may_be_converted_to_a_default_im…
808ccb7 
…port` codefix when the original node has export modifier
@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label Feb 13, 2025
@jakebailey
Copy link
Member

I merged #61171 without noticing that this was also available to fix the same issue; this one seemingly fixes the bug by actually implementing it, though #61171 used a the right helper for detecting the modifier (so that could be done here).

@Andarist
Copy link
Contributor Author

Jinx. I haven't seen the other PR :D I synced this now with main and used suggested helper

@Andarist Andarist force-pushed the fix/include-export-in-convert-to-defaut branch from cf6dd34 to 6aabbb7 Compare February 22, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
For Backlog Bug PRs that fix a backlog bug
Projects
PR Backlog
Status: Not started
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect "Import may be converted to a default import" autofix for import export
3 participants
@Andarist @jakebailey @typescript-bot