Fix the issue where modifying extraFileExtensions through ProjectService.setHostConfiguration in the plugin has no effect.
#61303
+17
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlgq
changed the title
src/server/editorServices.ts
Outdated
| @@ -2934,9 +2934,9 @@ export class ProjectService { | |||
| project.enableLanguageService(); | |||
| this.watchWildcards(configFilename, configFileExistenceInfo, project); | |||
| } | |||
| project.enablePluginsWithOptions(compilerOptions); | |||
| const filesToAdd = parsedCommandLine.fileNames.concat(project.getExternalFiles(ProgramUpdateLevel.Full)); | |||
There was a problem hiding this comment.
This move doesn't seem correct. Plugins can and do modify the results of getExternalFiles -- that API exists in the first place to support plugins.
There was a problem hiding this comment.
You are right. I think we can add an attribute to Project to determine whether a plugin has modified extraFileExtensions, and use this to ensure that only the innermost recursive call to updateRootAndOptionsOfNonInferredProject is made.
typescript-bot
added
the
For Uncommitted Bug
|
@microsoft-github-policy-service agree |
mlgq
changed the title
extraFileExtensions through ProjectService.setHostConfiguration in the plugin has no effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the plugin is enabled before
this.updateRootAndOptionsOfNonInferredProjectand the project service host configuration is changed throughprojectService.setHostConfigurationin the plugin, enabling the plugin will result in a recursive call toloadConfiguredProject, then the outerloadConfiguredProjectwill finally callthis.updateRootAndOptionsOfNonInferredProjectwith the parameters that before the plug-in was enabled.Fixes #61302