-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability for markdown file browser to display json files #5463
base: main
Are you sure you want to change the base?
Conversation
@microsoft-github-policy-service agree |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will work as-is, and I'll approve it.
Note however that the next version of MarkItDown will support json files, and so we may revisit this.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
==========================================
- Coverage 75.58% 75.49% -0.09%
==========================================
Files 189 189
Lines 12669 12688 +19
==========================================
+ Hits 9576 9579 +3
- Misses 3093 3109 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@brimock are you interested in continuing this? There are some CI failures that need to be addressed |
yes I am still interested, I can look into fixing it this weekend |
Why are these changes needed?
Enable the MarkdownFileBrowser to display '.json' files, such as a package.json file of a react package.
Related issue number
Checks