-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added http_client option to the BaseOpenAIClientConfiguration class #5811
base: main
Are you sure you want to change the base?
Added http_client option to the BaseOpenAIClientConfiguration class #5811
Conversation
Added http_client option to the BaseOpenAIClientConfiguration class, to support SSL verification option in model_client intiation.
To support SSL verification option in model_client intiation.
python/packages/autogen-ext/src/autogen_ext/models/openai/config/__init__.py
Outdated
Show resolved
Hide resolved
To support SSL verification option in model_client intiation.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5811 +/- ##
=======================================
Coverage 75.58% 75.58%
=======================================
Files 189 189
Lines 12669 12671 +2
=======================================
+ Hits 9576 9578 +2
Misses 3093 3093
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@avinashmihani actually I just realized the Does this change actually resolves #5795 ? |
@ekzhu Yes, this change worked. I tested in my local. With this change, I am able to update SSL verification value in v0.4.x. |
The problem though is that |
You can't put anything into that dictionary that is not json serializable so this is not going to work. This is required for the component config feature. If a python object must be passed it must be done directly via the constructor and so it wont be supported via config. If it is necesasary to support this argument we will need to strip it out of the exported config dictionary in _to_config |
Added http_client option to the BaseOpenAIClientConfiguration class, to support SSL verification option in model_client intiation.
Why are these changes needed?
In v0.2.x the agents to interact with LLM, was expecting LLM_CONFIG, which had an option to skip the SSL verification. Now in v0.4.x, the model client initiation does not have an option for skipping verification.
With this change, v0.4 as well will allow http_client option in model_client initiation
Related issue number
Closes #5795
Checks