Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update quickstart.ipynb #5815

Merged
merged 6 commits into from
Mar 6, 2025
Merged

Update quickstart.ipynb #5815

merged 6 commits into from
Mar 6, 2025

Conversation

taswar
Copy link
Contributor

@taswar taswar commented Mar 4, 2025

Added notice for user who are not using Jypter Notebook for the example, to wrap with asyncio

Why are these changes needed?

if a person uses VSCode they may not be able to run the sample code of SingleThreadedAgentRuntime since it has await calls, so just a line to explain if you are using VSCode remember to add async def main() to the code base.

Just a extra comment to remind VSCode users.

Related issue number

Checks

taswar and others added 2 commits March 4, 2025 15:53
Added notice for user who are not using Jypter Notebook for the example, to wrap with asyncio
Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.58%. Comparing base (9d235d2) to head (910bd94).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5815   +/-   ##
=======================================
  Coverage   75.58%   75.58%           
=======================================
  Files         189      189           
  Lines       12672    12672           
=======================================
  Hits         9578     9578           
  Misses       3094     3094           
Flag Coverage Δ
unittests 75.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 4, 2025

@taswar you need to agree to the CLA for us to merge your PR

@taswar
Copy link
Contributor Author

taswar commented Mar 4, 2025 via email

@ekzhu
Copy link
Collaborator

ekzhu commented Mar 4, 2025

@taswar please use the template

@microsoft-github-policy-service agree [company="{your company}"]

@taswar
Copy link
Contributor Author

taswar commented Mar 5, 2025

@microsoft-github-policy-service agree company="Microsoft"

@ekzhu ekzhu enabled auto-merge (squash) March 6, 2025 14:40
@ekzhu ekzhu disabled auto-merge March 6, 2025 14:42
@ekzhu ekzhu enabled auto-merge (squash) March 6, 2025 14:43
@ekzhu ekzhu disabled auto-merge March 6, 2025 14:44
@ekzhu ekzhu enabled auto-merge (squash) March 6, 2025 14:44
@ekzhu ekzhu merged commit 7d17ac8 into microsoft:main Mar 6, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants